Decouple rootless value from image name generation. #532
Labels
No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: gitea/helm-chart#532
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Currently you are required to have a tag that has the suffix
-rootless
with the helper forgitea.image
. By making this change you could use another image (say the Iron Bank one, that doesn't append-rootless
to the tag.You are right. Using a different image is currently not easily possible, if possible.
From a design perspective we then should move
image.rootless
out ofimage
and append the-rootless
suffix only forgitea/gitea
images. To make it fully flexible, there should probably be animage.fullOverride
or so to prevent possible false-positivegitea/gitea
detections.Feel free to open a PR for it.
PR opened #534
saw this hasn't been touched in a few weeks so I made a new PR, #550, incorporating the changes @dgershman made with unit tests. Happy to have the unit tests merged into his PR and close mine, just wasn't sure what the right protocol was to continue the work he's already done.
Note: to get unit tests to pass locally i had to update the template paths (e.g
templates/gitea/deployment.yaml
-->../../templates/gitea/deployment.yaml
) unless I removed thetemplates
field from the test suite and added the needed template path to each test. I didn't commit those changes cause I assumed the setup should work correctly in CI.Thanks for continuing this and adding tests.
This seems to be an issue with the latest unittest plugin version. I experienced the same locally when I tried upgrading it. But didn't had enough time at that moment to dive deeper into it.
Interesting. I was wondering if it was a new version issue, but similarly didn't have time to look too closely at it. Thanks for taking a look at the PR.
Since @dgershman hasn't commented on this effort in quite a while is it possible to move forward with the PR I opened? Are there any other changes y'all would like to see?
I'd be in favor of your PR over mine.