gitea/helm-chart
45
54
Fork 127
Code Issues 31 Pull Requests 7 Actions Releases 87 Activity

Quote image tag #641

Merged
pat-s merged 7 commits from quote-image-tag into main 2024-05-02 08:05:26 +00:00
Conversation 2 Commits 7 Files Changed 2 +18 -1
pat-s commented 2024-04-16 08:25:23 +00:00
Member
Copy Link

fix #631

fix #631
pat-s added 1 commit 2024-04-16 08:25:23 +00:00
quote image tag
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 18s
Details
002f2c3aa6
pat-s added 1 commit 2024-04-16 08:31:12 +00:00
adjust deployment file
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 32s
Details
2295142bae
pat-s changed title from Quote image tag to WIP: Quote image tag 2024-04-16 08:35:39 +00:00
justusbunsi added 4 commits 2024-05-01 17:42:43 +00:00
Add failing test showing the issue 
Signed-off-by: justusbunsi <sk.bunsenbrenner@gmail.com>
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 28s
Details
46e4c53a7c
justusbunsi added 1 commit 2024-05-01 17:46:13 +00:00
Ensure to convert potential float64 to string 
Signed-off-by: justusbunsi <sk.bunsenbrenner@gmail.com>
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 33s
Details
7c15385781
justusbunsi changed title from WIP: Quote image tag to Quote image tag 2024-05-01 17:46:53 +00:00
pat-s requested review from justusbunsi 2024-05-01 17:46:53 +00:00
justusbunsi refused to review 2024-05-01 17:47:12 +00:00
justusbunsi commented 2024-05-01 17:49:44 +00:00
Member
Copy Link

@pat-s It seems quote was not the right method to use here. There is a toString that work like you expected. I leave it up to you to merge, after you had the change to review my changes.

@pat-s It seems `quote` was not the right method to use here. There is a `toString` that work like you expected. I leave it up to you to merge, after you had the change to review my changes.
pat-s commented 2024-05-02 08:05:18 +00:00
Author
Member
Copy Link

Ah, nice! I was wondering a bit when I tried it, but had no time to dig deeper...

I've got to check what quote is actually doing then and in which situations it should be used. (looks like it really "only" quotes the value but doesn't do a type change - which seems required here?)

Ah, nice! I was wondering a bit when I tried it, but had no time to dig deeper... I've got to check what `quote` is actually doing then and in which situations it should be used. (looks like it really "only" quotes the value but doesn't do a type change - which seems required here?)
pat-s merged commit 0b2f3d6eb9 into main 2024-05-02 08:05:26 +00:00
pat-s referenced this issue from a commit 2024-05-02 08:05:26 +00:00
Quote image tag (#641)
pat-s deleted branch quote-image-tag 2024-05-02 08:05:29 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#641
No description provided.
Delete Branch "quote-image-tag"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?