actions/gitea-release-action
6
4
Fork 0
Code Issues 1 Pull Requests Actions Projects Releases Wiki Activity

"prerelease: false" has been handled as true #4

New Issue
Closed
opened 2024-04-18 02:56:10 +00:00 by wolfogre · 2 comments
wolfogre commented 2024-04-18 02:56:10 +00:00
Owner
Copy Link

It causes gitea/act#110

The point is

main.js Lines 18 to 19 in 89861ccfb7
const draft = Boolean(core.getInput("draft"))
const prerelease = Boolean(core.getInput("prerelease"))

However, https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Boolean#boolean_coercion

The empty string "" turns into false; other strings turn into true.

So Boolean("false") returns true.

image
It causes https://gitea.com/gitea/act/issues/110 The point is https://gitea.com/actions/gitea-release-action/src/commit/89861ccfb7d1b0e52ed87b5493c447de4f99e2f8/main.js#L18-L19 However, https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Boolean#boolean_coercion > The empty string "" turns into false; other strings turn into true. So `Boolean("false")` returns `true`. <img width="202" alt="image" src="/attachments/9a6c7787-1fc5-460f-97cf-79b10e9abd5e">
image.png
23 KiB
👍 2 👀 1
wolfogre added the
bug
 label 2024-04-18 02:56:10 +00:00
allen.cai commented 2024-05-06 03:28:07 +00:00
Copy Link

Ahhhhhh, the familiar taste!
This reminds me of the Azure DevOps Pipeline task extensions.
Let's follow up on here.

Ahhhhhh, the familiar taste! This reminds me of the Azure DevOps Pipeline task extensions. Let's follow up on here.
Akkuman commented 2024-05-06 15:17:25 +00:00
Member
Copy Link

f119011bd6

https://gitea.com/actions/gitea-release-action/commit/f119011bd6c95ab53d2084ace7b539694ce9b252
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
v1
v1.3.2
v1.3.1
v1.3.0
v1.1.6
v1.1.5
v1.1.4
v1.1.3
v1.1.2
v1.1.1
v1.1.0
v1.0.0
v0.0.10
v0.0.9
v0.0.8
v0.0.7
v0.0.6
v0.0.5
v0.0.4
v0.0.3
v0.0.2
v0.0.1
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: actions/gitea-release-action#4
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?