gitea/act
43
19
Fork 25
Code Issues 5 Pull Requests 3 Actions Releases 26 Activity

Support reusable workflow #34

Merged
wolfogre merged 6 commits from Zettat123/act:fix-reusable-workflow into main 2023-03-29 05:59:23 +00:00
Conversation 3 Commits 6 Files Changed 2 +57 -8
Zettat123 commented 2023-03-27 10:32:09 +00:00
Member
Copy Link

Fix gitea/act_runner#80
Fix gitea/act_runner#85

To support reusable workflows, I made some improvements:

  • read yml files from both .gitea/workflows and .github/workflows
  • clone repository for local reusable workflows because the runner doesn't have the code in its local directory
  • fix the incorrect clone url like https://https://gitea.com
Fix https://gitea.com/gitea/act_runner/issues/80 Fix https://gitea.com/gitea/act_runner/issues/85 To support reusable workflows, I made some improvements: - read `yml` files from both `.gitea/workflows` and `.github/workflows` - clone repository for local reusable workflows because the runner doesn't have the code in its local directory - fix the incorrect clone url like `https://https://gitea.com`
👍 1
Zettat123 added 1 commit 2023-03-27 10:32:10 +00:00
support local reusable workflow
All checks were successful
check and test
Details
28f766c8ca
lunny reviewed 2023-03-27 12:33:36 +00:00
pkg/runner/reusable_workflow.go Outdated
@ -114,4 +128,3 @@
func newRemoteReusableWorkflow(uses string) *remoteReusableWorkflow {
// GitHub docs:
// https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_iduses
r := regexp.MustCompile(`^([^/]+)/([^/]+)/.github/workflows/([^@]+)@(.*)$`)
lunny commented 2023-03-27 12:33:36 +00:00
Owner
Copy Link

Should we support both?

Should we support both?
👍 1
Zettat123 added 1 commit 2023-03-28 02:45:10 +00:00
support gitea and github
All checks were successful
check and test
Details
848920306f
Zettat123 changed title from WIP: Support local reusable workflow to Support reusable workflow 2023-03-28 03:17:13 +00:00
Zettat123 commented 2023-03-28 03:27:35 +00:00
Author
Member
Copy Link

Now we use the remoteReusableWorkflow struct in both newLocalReusableWorkflowExecutor and newRemoteReusableWorkflowExecutor. So I think it might be better to rename remoteReusableWorkflow to reusableWorkflow and improve the two functions to simplify the code. But I'm concerned that the refactor might cause more conflicts when we update from upstream.

Now we use the `remoteReusableWorkflow` struct in both `newLocalReusableWorkflowExecutor` and `newRemoteReusableWorkflowExecutor`. So I think it might be better to rename `remoteReusableWorkflow` to `reusableWorkflow` and improve the two functions to simplify the code. But I'm concerned that the refactor might cause more conflicts when we update from upstream.
Zettat123 added 1 commit 2023-03-28 03:41:38 +00:00
fix JobType
All checks were successful
check and test
Details
f8ede23f3e
wolfogre commented 2023-03-28 03:53:01 +00:00
Owner
Copy Link

Now we use the remoteReusableWorkflow struct in both newLocalReusableWorkflowExecutor and newRemoteReusableWorkflowExecutor. So I think it might be better to rename remoteReusableWorkflow to reusableWorkflow and improve the two functions to simplify the code. But I'm concerned that the refactor might cause more conflicts when we update from upstream.

Please don't do refactor in a soft fork, just add a new function/type and mark the old one deprecated. Or I'll ask you to resolve conflicts when merging upstream. 🌚

> Now we use the `remoteReusableWorkflow` struct in both `newLocalReusableWorkflowExecutor` and `newRemoteReusableWorkflowExecutor`. So I think it might be better to rename `remoteReusableWorkflow` to `reusableWorkflow` and improve the two functions to simplify the code. But I'm concerned that the refactor might cause more conflicts when we update from upstream. Please don't do refactor in a soft fork, just add a new function/type and mark the old one deprecated. Or I'll ask you to resolve conflicts when merging upstream. 🌚
👍 1
Zettat123 added 1 commit 2023-03-28 04:08:09 +00:00
reduce diff
All checks were successful
check and test
Details
35303173d6
Zettat123 commented 2023-03-28 04:09:42 +00:00
Author
Member
Copy Link

Please don't do refactor in a soft fork

You're right. We should minimize the differences with upstream.

> Please don't do refactor in a soft fork You're right. We should minimize the differences with upstream.
Zettat123 added 1 commit 2023-03-28 04:11:09 +00:00
add comment
All checks were successful
check and test
Details
7290c4cb6e
wolfogre approved these changes 2023-03-29 05:58:21 +00:00
wolfogre added 1 commit 2023-03-29 05:58:30 +00:00
wolfogre merged commit 5e76853b55 into main 2023-03-29 05:59:23 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
wolfogre
Labels
Clear labels   
duplicate

This issue or pull request already exists

  
help wanted

Need some help

  
invalid

Something is wrong

  
kind
bug
Something is not working

  
kind
enhancement
New feature

  
kind
feature

  
kind
question
More information is needed

  
proposal

   
wontfix

This won't be fixed

No Label
duplicate
help wanted
invalid
kind
bug
kind
enhancement
kind
feature
kind
question
proposal
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/act#34
No description provided.
Delete Branch "Zettat123/act:fix-reusable-workflow"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?