Improve the default label #104

New Issue

yp05327 · 2023-04-06T13:22:46Z

yp05327 commented

2023-04-06 13:22:46 +00:00

The recent default labels are all named like docker image tags which are easily misunderstanded by first-time users.
I have seen several times that they use ‘runs-on: ImageTag’ instead of ‘container.image:ImageTag’ when they want to use custom image.

Not all users have an experience of Github Actions, maybe we can use several different types in default labels, like:

image tags: Ubuntu-latest
docker or self-hosted: docker
custom runner name: my runner

The recent default labels are all named like docker image tags which are easily misunderstanded by first-time users. I have seen several times that they use ‘runs-on: ImageTag’ instead of ‘container.image:ImageTag’ when they want to use custom image. Not all users have an experience of Github Actions, maybe we can use several different types in default labels, like: - image tags: Ubuntu-latest - docker or self-hosted: docker - custom runner name: my runner

lunny added the

kind

proposal

label 2023-04-06 13:54:44 +00:00

Zettat123 commented

2023-04-07 01:30:37 +00:00

maybe related to #69

wolfogre commented

2023-04-07 06:57:58 +00:00

IMO, default labels are not example labels, they should be safe to running a runner when the user have no idea what it means.

This is why I am against Add "self-hosted" to default labels.

I'll agree to provide more documents to let users understand how the labels work, like https://blog.gitea.io/2023/03/hacking-on-gitea-actions/#act-runner (maybe not obvious enough), but keep the default labels boring and safe.

TODO: #106

IMO, default labels are not example labels, they should be safe to running a runner when the user have no idea what it means. This is why I am against [Add "self-hosted" to default labels](https://gitea.com/gitea/act_runner/pulls/17). I'll agree to provide more documents to let users understand how the labels work, like https://blog.gitea.io/2023/03/hacking-on-gitea-actions/#act-runner (maybe not obvious enough), but keep the default labels boring and safe. TODO: https://gitea.com/gitea/act_runner/issues/106

wolfogre closed this issue

2023-04-07 06:57:58 +00:00

wolfogre referenced this issue

2023-04-07 07:02:11 +00:00

Add introduction about how labels work to README #106

Sign in to join this conversation.