Improve the default label #104

Closed
opened 2023-04-06 13:22:46 +00:00 by yp05327 · 2 comments

The recent default labels are all named like docker image tags which are easily misunderstanded by first-time users.
I have seen several times that they use ‘runs-on: ImageTag’ instead of ‘container.image:ImageTag’ when they want to use custom image.

Not all users have an experience of Github Actions, maybe we can use several different types in default labels, like:

  • image tags: Ubuntu-latest
  • docker or self-hosted: docker
  • custom runner name: my runner
The recent default labels are all named like docker image tags which are easily misunderstanded by first-time users. I have seen several times that they use ‘runs-on: ImageTag’ instead of ‘container.image:ImageTag’ when they want to use custom image. Not all users have an experience of Github Actions, maybe we can use several different types in default labels, like: - image tags: Ubuntu-latest - docker or self-hosted: docker - custom runner name: my runner
lunny added the
kind
proposal
label 2023-04-06 13:54:44 +00:00
Member

maybe related to #69

maybe related to #69
Owner

IMO, default labels are not example labels, they should be safe to running a runner when the user have no idea what it means.

This is why I am against Add "self-hosted" to default labels.

I'll agree to provide more documents to let users understand how the labels work, like https://blog.gitea.io/2023/03/hacking-on-gitea-actions/#act-runner (maybe not obvious enough), but keep the default labels boring and safe.

TODO: #106

IMO, default labels are not example labels, they should be safe to running a runner when the user have no idea what it means. This is why I am against [Add "self-hosted" to default labels](https://gitea.com/gitea/act_runner/pulls/17). I'll agree to provide more documents to let users understand how the labels work, like https://blog.gitea.io/2023/03/hacking-on-gitea-actions/#act-runner (maybe not obvious enough), but keep the default labels boring and safe. TODO: https://gitea.com/gitea/act_runner/issues/106
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/act_runner#104
No description provided.