gitea/act_runner
61
106
Fork 79
Code Issues 137 Pull Requests 9 Actions Releases 21 Activity

Nil pointer when reusing local workflows #138

New Issue
Open
opened 2023-04-24 07:48:07 +00:00 by Zettat123 · 3 comments
Zettat123 commented 2023-04-24 07:48:07 +00:00
Member
Copy Link

Copy from #132 (comment)

Hi.
In the latest build there is more output reported to Gitea but reusing local workflows is still broken. Currently our daemon is restarting when it comes to the point of using the workflow:

Apr 24 09:13:48 pve107 act_runner[13636]: panic: runtime error: invalid memory address or nil pointer dereference
Apr 24 09:13:48 pve107 act_runner[13636]: [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xb86334]
Apr 24 09:13:48 pve107 act_runner[13636]: goroutine 316 [running]:
Apr 24 09:13:48 pve107 act_runner[13636]: github.com/nektos/act/pkg/runner.setupWorkflowInputs({0x12411e0, 0xc0005e20c0}, 0xc00018ea78, 0xc000256120)
Apr 24 09:13:48 pve107 act_runner[13636]:         github.com/nektos/act@v0.0.0/pkg/runner/expression.go:383 +0x74
Apr 24 09:13:48 pve107 act_runner[13636]: github.com/nektos/act/pkg/runner.getEvaluatorInputs({0x12411e0, 0xc0005e20c0}, 0xc000256120, {0x0, 0x0}, 0xc000465a00)
Apr 24 09:13:48 pve107 act_runner[13636]:         github.com/nektos/act@v0.0.0/pkg/runner/expression.go:344 +0x85
Apr 24 09:13:48 pve107 act_runner[13636]: github.com/nektos/act/pkg/runner.(*RunContext).NewExpressionEvaluatorWithEnv(0xc000256120, {0x12411e0, 0xc0005e20c0}, 0xc0004c07e0)
Apr 24 09:13:48 pve107 act_runner[13636]:         github.com/nektos/act@v0.0.0/pkg/runner/expression.go:69 +0x61b
Apr 24 09:13:48 pve107 act_runner[13636]: github.com/nektos/act/pkg/runner.(*RunContext).NewExpressionEvaluator(0xc00018ef20?, {0x12411e0, 0xc0005e20c0})
Apr 24 09:13:48 pve107 act_runner[13636]:         github.com/nektos/act@v0.0.0/pkg/runner/expression.go:24 +0x3f
Apr 24 09:13:48 pve107 act_runner[13636]: github.com/nektos/act/pkg/runner.(*runnerImpl).newRunContext(0xc0003aa580, {0x12411e0, 0xc0005e20c0}, 0xc0003ff488, 0xc0004c0720)
Apr 24 09:13:48 pve107 act_runner[13636]:         github.com/nektos/act@v0.0.0/pkg/runner/runner.go:208 +0x139
Apr 24 09:13:48 pve107 act_runner[13636]: github.com/nektos/act/pkg/runner.(*runnerImpl).NewPlanExecutor.func1({0x12411e0, 0xc0005e20c0})
Apr 24 09:13:48 pve107 act_runner[13636]:         github.com/nektos/act@v0.0.0/pkg/runner/runner.go:156 +0x65f
Apr 24 09:13:48 pve107 act_runner[13636]: github.com/nektos/act/pkg/common.Executor.Then.func1({0x12411e0, 0xc0005e20c0})
Apr 24 09:13:48 pve107 act_runner[13636]:         github.com/nektos/act@v0.0.0/pkg/common/executor.go:129 +0x34
Apr 24 09:13:48 pve107 act_runner[13636]: github.com/nektos/act/pkg/runner.newReusableWorkflowExecutor.func1({0x12411e0, 0xc0005e20c0})

Workflows are very simple due to testing. Parent workflow is echoing some text and should then use the second workflow. The second workflow should run when the workflow_call event is triggered and should echo another string.

Copy from https://gitea.com/gitea/act_runner/issues/132#issuecomment-739199 --- Hi. In the latest build there is more output reported to Gitea but reusing local workflows is still broken. Currently our daemon is restarting when it comes to the point of using the workflow: ``` Apr 24 09:13:48 pve107 act_runner[13636]: panic: runtime error: invalid memory address or nil pointer dereference Apr 24 09:13:48 pve107 act_runner[13636]: [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xb86334] Apr 24 09:13:48 pve107 act_runner[13636]: goroutine 316 [running]: Apr 24 09:13:48 pve107 act_runner[13636]: github.com/nektos/act/pkg/runner.setupWorkflowInputs({0x12411e0, 0xc0005e20c0}, 0xc00018ea78, 0xc000256120) Apr 24 09:13:48 pve107 act_runner[13636]: github.com/nektos/act@v0.0.0/pkg/runner/expression.go:383 +0x74 Apr 24 09:13:48 pve107 act_runner[13636]: github.com/nektos/act/pkg/runner.getEvaluatorInputs({0x12411e0, 0xc0005e20c0}, 0xc000256120, {0x0, 0x0}, 0xc000465a00) Apr 24 09:13:48 pve107 act_runner[13636]: github.com/nektos/act@v0.0.0/pkg/runner/expression.go:344 +0x85 Apr 24 09:13:48 pve107 act_runner[13636]: github.com/nektos/act/pkg/runner.(*RunContext).NewExpressionEvaluatorWithEnv(0xc000256120, {0x12411e0, 0xc0005e20c0}, 0xc0004c07e0) Apr 24 09:13:48 pve107 act_runner[13636]: github.com/nektos/act@v0.0.0/pkg/runner/expression.go:69 +0x61b Apr 24 09:13:48 pve107 act_runner[13636]: github.com/nektos/act/pkg/runner.(*RunContext).NewExpressionEvaluator(0xc00018ef20?, {0x12411e0, 0xc0005e20c0}) Apr 24 09:13:48 pve107 act_runner[13636]: github.com/nektos/act@v0.0.0/pkg/runner/expression.go:24 +0x3f Apr 24 09:13:48 pve107 act_runner[13636]: github.com/nektos/act/pkg/runner.(*runnerImpl).newRunContext(0xc0003aa580, {0x12411e0, 0xc0005e20c0}, 0xc0003ff488, 0xc0004c0720) Apr 24 09:13:48 pve107 act_runner[13636]: github.com/nektos/act@v0.0.0/pkg/runner/runner.go:208 +0x139 Apr 24 09:13:48 pve107 act_runner[13636]: github.com/nektos/act/pkg/runner.(*runnerImpl).NewPlanExecutor.func1({0x12411e0, 0xc0005e20c0}) Apr 24 09:13:48 pve107 act_runner[13636]: github.com/nektos/act@v0.0.0/pkg/runner/runner.go:156 +0x65f Apr 24 09:13:48 pve107 act_runner[13636]: github.com/nektos/act/pkg/common.Executor.Then.func1({0x12411e0, 0xc0005e20c0}) Apr 24 09:13:48 pve107 act_runner[13636]: github.com/nektos/act@v0.0.0/pkg/common/executor.go:129 +0x34 Apr 24 09:13:48 pve107 act_runner[13636]: github.com/nektos/act/pkg/runner.newReusableWorkflowExecutor.func1({0x12411e0, 0xc0005e20c0}) ``` Workflows are very simple due to testing. Parent workflow is echoing some text and should then use the second workflow. The second workflow should run when the `workflow_call` event is triggered and should echo another string.
Zettat123 commented 2023-04-24 07:54:46 +00:00
Author
Member
Copy Link

There is a workaround. Could you please add the inputs keyword and test again? @dwillbrandt

Sorry, I didn't see your comment #132 (comment)
This is a bug, but changing the format of on: part is a workaround and could avoid the nil pointer.

Works but gives no output on the steps (maybe expected?)

You should see the output in the Set up job section.

~~There is a workaround. Could you please add the `inputs` keyword and test again? @dwillbrandt~~ --- Sorry, I didn't see your comment https://gitea.com/gitea/act_runner/issues/132#issuecomment-739201 This is a bug, but changing the format of `on:` part is a workaround and could avoid the nil pointer. > Works but gives no output on the steps (maybe expected?) You should see the output in the `Set up job` section.
ChristopherHX commented 2023-04-24 08:31:10 +00:00
Contributor
Copy Link

The mentioned crash has been fixed upstream d70b225e85, you can cherry pick / update the fork.

The mentioned crash has been fixed upstream https://github.com/nektos/act/commit/d70b225e85b44efdcd97452959a3bbabec5eb6ed, you can cherry pick / update the fork.
👍 1
wolfogre commented 2023-04-24 08:37:02 +00:00
Owner
Copy Link

The mentioned crash has been fixed upstream d70b225e85, you can cherry pick / update the fork.

I would merge it when upstream has released a tag containing it.

> The mentioned crash has been fixed upstream https://github.com/nektos/act/commit/d70b225e85b44efdcd97452959a3bbabec5eb6ed, you can cherry pick / update the fork. I would merge it when upstream has released a tag containing it.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
renovate/github.com-nektos-act-0.x
renovate/alpine-3.x
renovate/actions-setup-go-5.x
renovate/golang.org-x-term-0.x
v0.2.10
v0.2.9
v0.2.8
v0.2.7
v0.2.6
v0.2.5
v0.2.4
v0.2.3
v0.2.2
v0.2.1
v0.2.0
v0.1.8
v0.1.7
v0.1.6
v0.1.5
v0.1.4
v0.1.3
v0.1.2
v0.1.1
v0.1.0
v0.0.1
Labels
Clear labels   
kind
bug
Something is not working

  
kind
build

  
kind/compatible
  
kind
dependencies

  
kind
docs

  
kind
enhancement
New feature

  
kind
feature

  
kind
help wanted
Need some help

  
kind
proposal

  
kind
refactor

  
related
act
Related to act.

  
related
environment
Related to the environment.

  
related
exec

  
related
gitea
Related to Gitea.

  
related
workflow
Related to the workflow file or actions scripts.

  
reviewed
confirmed
confirmed issue

  
reviewed
duplicate
This issue or pull request already exists

  
reviewed
invalid
Something is wrong

  
reviewed
needs feedback

  
reviewed
wontfix
This won't be fixed

  
reviewed
workaround

No Label
kind
bug
kind
build
kind/compatible
kind
dependencies
kind
docs
kind
enhancement
kind
feature
kind
help wanted
kind
proposal
kind
refactor
related
act
related
environment
related
exec
related
gitea
related
workflow
reviewed
confirmed
reviewed
duplicate
reviewed
invalid
reviewed
needs feedback
reviewed
wontfix
reviewed
workaround
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/act_runner#138
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?