feature: helm chart for act_runner for dind and rootless runners #267

New Issue

ccureau · 2023-07-02T14:18:03Z

ccureau commented

2023-07-02 14:18:03 +00:00

The project currently lacks an automated way to deploy the runner and have it automatically connect to the Gitea instance, which increases the barrier to entry for not-so-seasoned folks.

The chart should:

Register given a token
Create a pvc that will store the configuration and registration info
Create a configuration file based on chart inputs

The project currently lacks an automated way to deploy the runner and have it automatically connect to the Gitea instance, which increases the barrier to entry for not-so-seasoned folks. The chart should: - Register given a token - Create a pvc that will store the configuration and registration info - Create a configuration file based on chart inputs

👍 1

ccureau referenced this issue

2023-07-02 14:20:27 +00:00

Kubernetes example not working (waiting for docker daemon...) #249

PatrickLaabs commented

2023-07-02 15:50:12 +00:00

Not sure, if you want a separate helm chart for this deployment. But, as a user, I’d like to have the ability to enable the runners deployment within the gitea helm chart.

Maybe extending the existing helm chart is the better approach.

But I am fairly new to the project and not sure, if the implementation into the existing gitea helm chart is as easy as I am currently guessing :)

Not sure, if you want a separate helm chart for this deployment. But, as a user, I’d like to have the ability to enable the runners deployment within the gitea helm chart. Maybe extending the existing helm chart is the better approach. But I am fairly new to the project and not sure, if the implementation into the existing gitea helm chart is as easy as I am currently guessing :)

lunny commented

2023-07-03 01:23:24 +00:00

Maybe related gitea/helm-chart#459

pat-s commented

2023-07-03 07:06:58 +00:00

Being a helm chart maintainer, this part should/could definitely go into the existing chart. However somebody needs to do it and AFAIK nobody of the current maintainers is actively using Actions yet (e.g. we went for Woodpecker).

So there might be effort from outside needed regarding the initial implementation (I am myself try to push the HA concept when I find some time...).

Happy to review and help. A brief concept outlined in an issue might be helpful!

Being a helm chart maintainer, this part should/could definitely go into the existing chart. However somebody needs to do it and AFAIK nobody of the current maintainers is actively using Actions yet (e.g. we went for Woodpecker). So there might be effort from outside needed regarding the initial implementation (I am myself try to push the HA concept when I find some time...). Happy to review and help. A brief concept outlined in an issue might be helpful!

kha7iq commented

2023-11-03 16:23:28 +00:00

I recently created a chart for runner deployment and did some testing happy to open a PR if needed.
https://github.com/kha7iq/charts/tree/main/charts/act-runner

I recently created a chart for runner deployment and did some testing happy to open a PR if needed. https://github.com/kha7iq/charts/tree/main/charts/act-runner

pat-s commented

2023-11-04 09:44:07 +00:00

Thanks for the effort! Yes, we weren't really pushing for an integration of act runners in the chart yet.

Are you planning to maintain it longterm? That is usually the biggest issue.

Another option would also to move it to gitea.com and add it as sub-chart, so users can managed everything in one place and only need to use act_runner: enabled (or similar).

For this it would need some unit tests similar to the main chart and align with the current workflows etc.
If you want to keep it on GH under your name, this is also fine. We can link it in the README but might at some point add a different solution for runners then.

Thanks for the effort! Yes, we weren't really pushing for an integration of act runners in the chart yet. Are you planning to maintain it longterm? That is usually the biggest issue. Another option would also to move it to gitea.com and add it as sub-chart, so users can managed everything in one place and only need to use `act_runner: enabled` (or similar). For this it would need some unit tests similar to the main chart and align with the current workflows etc. If you want to keep it on GH under your name, this is also fine. We can link it in the README but might at some point add a different solution for runners then.

kha7iq commented

2023-11-05 05:11:56 +00:00

I am planing to maintain it.
In my opinion keeping it as a separate chart might be a better approach, unless on a new deployment of gitea itself there is a way to automatically get the runner registration token at instance level.

If you feel like you are not at a point to include a runner chart, i will maintain it on GH. otherwise just let me know where the chart should go and i will open a PR.

I am planing to maintain it. In my opinion keeping it as a separate chart might be a better approach, unless on a new deployment of gitea itself there is a way to automatically get the runner registration token at instance level. If you feel like you are not at a point to include a runner chart, i will maintain it on GH. otherwise just let me know where the chart should go and i will open a PR.

pat-s commented

2023-11-06 08:24:38 +00:00

In my opinion keeping it as a separate chart might be a better approach, unless on a new deployment of gitea itself there is a way to automatically get the runner registration token at instance level.

With an init-container this could be done I guess. This would probably be the bigger advantage of coupling them, to have a seamless token creation/sharing. Albeit this might also be possible if the chart is hosted separately and the gitea chart only imports it.

If you would move it into the existing chart repo, you would however not have full admin permissions there (at least not from the beginning) and be somewhat dependent on the activity of the chart maintainers. Just mentioning this in case...

@justusbunsi What are your thoughts on this overall? If we would do so, we would have to restructure the repo to move the charts below charts/ rather than having it in the root like it is now.

> In my opinion keeping it as a separate chart might be a better approach, unless on a new deployment of gitea itself there is a way to automatically get the runner registration token at instance level. With an init-container this could be done I guess. This would probably be the bigger advantage of coupling them, to have a seamless token creation/sharing. Albeit this might also be possible if the chart is hosted separately and the gitea chart only imports it. If you would move it into the existing chart repo, you would however not have full admin permissions there (at least not from the beginning) and be somewhat dependent on the activity of the chart maintainers. Just mentioning this in case... @justusbunsi What are your thoughts on this overall? If we would do so, we would have to restructure the repo to move the charts below `charts/` rather than having it in the root like it is now.

vjm commented

2024-04-30 02:30:29 +00:00

Hi -- any progress on this? I would be happy to contribute to making this a part of the main helm chart.

justusbunsi commented

2024-04-30 04:55:47 +00:00

There are efforts in the Helm Chart repo. gitea/helm-chart#596

There are efforts in the Helm Chart repo. https://gitea.com/gitea/helm-chart/pulls/596

Sign in to join this conversation.

No Milestone

No Assignees

7 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/act_runner#267