act_runner incorrectly uses DOCKER_USERNAME secret #386

New Issue

ExplodingDragon · 2023-10-25T07:26:35Z

ExplodingDragon commented

2023-10-25 07:26:35 +00:00

If DOCKER_USERNAME and DOCKER_PASSWORD are configured under Secrets , act_runner will use them when pulling images.

		pkg/runner/step_docker.go
		Line 121 in c93462e19f
	
						Username:     rc.Config.Secrets["DOCKER_USERNAME"],

Incorrect account passwords will cause it to fail even if the image is public.

This option should be moved to the config file.

If `DOCKER_USERNAME` and `DOCKER_PASSWORD` are configured under Secrets , act_runner will use them when pulling images. https://gitea.com/gitea/act/src/commit/c93462e19f612a4bef5bf616ff835ed869debfef/pkg/runner/step_docker.go#L121 Incorrect account passwords will cause it to fail even if the image is public. ![image](/attachments/0ee127d3-f67a-472f-be4c-4710dffdec21) This option should be moved to the config file.

image.png

76 KiB

lng2020 added the

kind

bug

label 2023-11-17 10:03:21 +00:00

Sign in to join this conversation.