gitea/act_runner
62
108
Fork 81
Code Issues 139 Pull Requests 10 Actions Releases 21 Activity

configuration setting log.level has no effect (always logging at DEBUG level) #409

New Issue
Open
opened 2023-11-22 22:36:39 +00:00 by nodiscc · 2 comments
nodiscc commented 2023-11-22 22:36:39 +00:00
Copy Link

Lowering the log level to warn in the configuration file has no effect, [DEBUG] messages and job logs are still being logged to stdout/journald/syslog:

# /etc/act-runner/config.yaml
log:
  level: warn

$ sudo systemctl restart act-runner
# run a job from gitea's web interface

$ grep act-runner /var/log/syslog
Nov 22 23:27:46 home systemd[1]: Stopping act-runner.service - Gitea Actions runner...
Nov 22 23:27:46 home systemd[1]: act-runner.service: Deactivated successfully.
Nov 22 23:27:46 home systemd[1]: Stopped act-runner.service - Gitea Actions runner.
Nov 22 23:27:46 home systemd[1]: act-runner.service: Consumed 1.365s CPU time.
Nov 22 23:27:46 home systemd[1]: Started act-runner.service - Gitea Actions runner.
Nov 22 23:27:46 home act-runner[916192]: time="2023-11-22T23:27:46+01:00" level=info msg="log level changed to warning"
Nov 22 23:27:47 home act-runner[916192]: time="2023-11-22T23:27:47+01:00" level=warning msg="Because the Gitea instance is an old version, skip declare labels and version."
Nov 22 23:28:02 home act-runner[916192]: [CI/check-and-deploy] [DEBUG] evaluating expression 'success()'
Nov 22 23:28:02 home act-runner[916192]: [CI/check-and-deploy] [DEBUG] expression 'success()' evaluated to 'true'
Nov 22 23:28:02 home act-runner[916192]: [CI/check-and-deploy] 🚀  Start image=node:16-bullseye
Nov 22 23:28:02 home act-runner[916192]: [CI/check-and-deploy]   🐳  docker pull image=node:16-bullseye platform= username= forcePull=false
Nov 22 23:28:02 home act-runner[916192]: [CI/check-and-deploy] [DEBUG]   🐳  docker pull node:16-bullseye
Nov 22 23:28:02 home act-runner[916192]: [CI/check-and-deploy] [DEBUG] Image exists? true
....
....
Nov 22 23:29:56 home act-runner[916192]: [CI/check-and-deploy] [DEBUG] Working directory '/var/lib/act-runner/.cache/act/example/example'
Nov 22 23:29:57 home act-runner[916192]: [CI/check-and-deploy]   |
Nov 22 23:29:57 home act-runner[916192]: [CI/check-and-deploy]   | WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
Nov 22 23:29:57 home act-runner[916192]: [CI/check-and-deploy]   |
Nov 22 23:29:58 home act-runner[916192]: [CI/check-and-deploy]   | Get:1 http://deb.debian.org/debian bullseye InRelease [116 kB]
Nov 22 23:29:59 home act-runner[916192]: [CI/check-and-deploy]   | Get:2 http://deb.debian.org/debian-security bullseye-security InRelease [48.4 kB]
Nov 22 23:30:00 home act-runner[916192]: [CI/check-and-deploy]   | Get:3 http://deb.debian.org/debian bullseye-updates InRelease [44.1 kB]
Nov 22 23:30:01 home act-runner[916192]: [CI/check-and-deploy]   | Get:4 http://deb.debian.org/debian bullseye/main amd64 Packages [8062 kB]
Nov 22 23:30:02 home act-runner[916192]: [CI/check-and-deploy]   | Get:5 http://deb.debian.org/debian-security bullseye-security/main amd64 Packages [258 kB]
Nov 22 23:30:02 home act-runner[916192]: [CI/check-and-deploy]   | Get:6 http://deb.debian.org/debian bullseye-updates/main amd64 Packages [17.7 kB]
Nov 22 23:30:03 home act-runner[916192]: [CI/check-and-deploy]   | Fetched 8546 kB in 5s (1589 kB/s)
Nov 22 23:30:03 home act-runner[916192]: [CI/check-and-deploy]   | Reading package lists...
Nov 22 23:30:04 home act-runner[916192]: [CI/check-and-deploy]   | Building dependency tree...
Nov 22 23:30:04 home act-runner[916192]: [CI/check-and-deploy]   | Reading state information...
Nov 22 23:30:04 home act-runner[916192]: [CI/check-and-deploy]   | 50 packages can be upgraded. Run 'apt list --upgradable' to see them.
Nov 22 23:30:04 home act-runner[916192]: [CI/check-and-deploy]   |
Nov 22 23:30:04 home act-runner[916192]: [CI/check-and-deploy]   | WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
Nov 22 23:30:04 home act-runner[916192]: [CI/check-and-deploy]   |
Nov 22 23:30:04 home act-runner[916192]: [CI/check-and-deploy]   | Reading package lists...
...

act_runner v0.2.6

Lowering the log level to `warn` in the configuration file has no effect, `[DEBUG]` messages and job logs are still being logged to stdout/journald/syslog: ```yaml # /etc/act-runner/config.yaml log: level: warn ``` ```bash $ sudo systemctl restart act-runner # run a job from gitea's web interface ``` ``` $ grep act-runner /var/log/syslog Nov 22 23:27:46 home systemd[1]: Stopping act-runner.service - Gitea Actions runner... Nov 22 23:27:46 home systemd[1]: act-runner.service: Deactivated successfully. Nov 22 23:27:46 home systemd[1]: Stopped act-runner.service - Gitea Actions runner. Nov 22 23:27:46 home systemd[1]: act-runner.service: Consumed 1.365s CPU time. Nov 22 23:27:46 home systemd[1]: Started act-runner.service - Gitea Actions runner. Nov 22 23:27:46 home act-runner[916192]: time="2023-11-22T23:27:46+01:00" level=info msg="log level changed to warning" Nov 22 23:27:47 home act-runner[916192]: time="2023-11-22T23:27:47+01:00" level=warning msg="Because the Gitea instance is an old version, skip declare labels and version." Nov 22 23:28:02 home act-runner[916192]: [CI/check-and-deploy] [DEBUG] evaluating expression 'success()' Nov 22 23:28:02 home act-runner[916192]: [CI/check-and-deploy] [DEBUG] expression 'success()' evaluated to 'true' Nov 22 23:28:02 home act-runner[916192]: [CI/check-and-deploy] 🚀 Start image=node:16-bullseye Nov 22 23:28:02 home act-runner[916192]: [CI/check-and-deploy] 🐳 docker pull image=node:16-bullseye platform= username= forcePull=false Nov 22 23:28:02 home act-runner[916192]: [CI/check-and-deploy] [DEBUG] 🐳 docker pull node:16-bullseye Nov 22 23:28:02 home act-runner[916192]: [CI/check-and-deploy] [DEBUG] Image exists? true .... .... Nov 22 23:29:56 home act-runner[916192]: [CI/check-and-deploy] [DEBUG] Working directory '/var/lib/act-runner/.cache/act/example/example' Nov 22 23:29:57 home act-runner[916192]: [CI/check-and-deploy] | Nov 22 23:29:57 home act-runner[916192]: [CI/check-and-deploy] | WARNING: apt does not have a stable CLI interface. Use with caution in scripts. Nov 22 23:29:57 home act-runner[916192]: [CI/check-and-deploy] | Nov 22 23:29:58 home act-runner[916192]: [CI/check-and-deploy] | Get:1 http://deb.debian.org/debian bullseye InRelease [116 kB] Nov 22 23:29:59 home act-runner[916192]: [CI/check-and-deploy] | Get:2 http://deb.debian.org/debian-security bullseye-security InRelease [48.4 kB] Nov 22 23:30:00 home act-runner[916192]: [CI/check-and-deploy] | Get:3 http://deb.debian.org/debian bullseye-updates InRelease [44.1 kB] Nov 22 23:30:01 home act-runner[916192]: [CI/check-and-deploy] | Get:4 http://deb.debian.org/debian bullseye/main amd64 Packages [8062 kB] Nov 22 23:30:02 home act-runner[916192]: [CI/check-and-deploy] | Get:5 http://deb.debian.org/debian-security bullseye-security/main amd64 Packages [258 kB] Nov 22 23:30:02 home act-runner[916192]: [CI/check-and-deploy] | Get:6 http://deb.debian.org/debian bullseye-updates/main amd64 Packages [17.7 kB] Nov 22 23:30:03 home act-runner[916192]: [CI/check-and-deploy] | Fetched 8546 kB in 5s (1589 kB/s) Nov 22 23:30:03 home act-runner[916192]: [CI/check-and-deploy] | Reading package lists... Nov 22 23:30:04 home act-runner[916192]: [CI/check-and-deploy] | Building dependency tree... Nov 22 23:30:04 home act-runner[916192]: [CI/check-and-deploy] | Reading state information... Nov 22 23:30:04 home act-runner[916192]: [CI/check-and-deploy] | 50 packages can be upgraded. Run 'apt list --upgradable' to see them. Nov 22 23:30:04 home act-runner[916192]: [CI/check-and-deploy] | Nov 22 23:30:04 home act-runner[916192]: [CI/check-and-deploy] | WARNING: apt does not have a stable CLI interface. Use with caution in scripts. Nov 22 23:30:04 home act-runner[916192]: [CI/check-and-deploy] | Nov 22 23:30:04 home act-runner[916192]: [CI/check-and-deploy] | Reading package lists... ... ``` act_runner v0.2.6
lng2020 added the
kind
bug
 label 2023-11-23 06:23:34 +00:00
nodiscc commented 2024-01-28 13:08:27 +00:00
Author
Copy Link

Hi,

any updates on this?

I have deployed act-runner as a systemd service and it is spamming syslog with all messages from the build output. The log is not even useful as output of all jobs are mangled together.

I could try to patch it but have no idea where to begin. Is this hard to fix?

Hi, any updates on this? I have deployed act-runner as a systemd service and it is spamming syslog with all messages from the build output. The log is not even useful as output of all jobs are mangled together. I could try to patch it but have no idea where to begin. Is this hard to fix?
johnatank commented 2024-02-18 15:42:53 +00:00
Copy Link

This seems to be the reason - if JobLoggerLevel in runner config is nil, trace level is set:

gitea.com\gitea\act@v0.251.1\pkg\runner\logger.go
func WithJobLogger(ctx context.Context, jobID string, jobName string, config *Config, masks *[]string, matrix map[string]interface{}) context.Context {
...
	{ // Adapt to Gitea
		if hook := common.LoggerHook(ctx); hook != nil {
			logger.AddHook(hook)
		}
		if config.JobLoggerLevel != nil {
			logger.SetLevel(*config.JobLoggerLevel)
		} else {
			logger.SetLevel(logrus.TraceLevel)
		}
	}

Seems like JobLoggerLevel isn't set when initializing plan executor:

internal\app\run\runner.go
	executor := rr.NewPlanExecutor(plan)


gitea.com\gitea\act@v0.251.1\pkg\runner\runner.go
func (runner *runnerImpl) NewPlanExecutor(plan *model.Plan) common.Executor {
...
						return executor(common.WithJobErrorContainer(WithJobLogger(ctx, rc.Run.JobID, jobName, rc.Config, &rc.Masks, matrix)))
This seems to be the reason - if JobLoggerLevel in runner config is nil, trace level is set: ``` gitea.com\gitea\act@v0.251.1\pkg\runner\logger.go func WithJobLogger(ctx context.Context, jobID string, jobName string, config *Config, masks *[]string, matrix map[string]interface{}) context.Context { ... { // Adapt to Gitea if hook := common.LoggerHook(ctx); hook != nil { logger.AddHook(hook) } if config.JobLoggerLevel != nil { logger.SetLevel(*config.JobLoggerLevel) } else { logger.SetLevel(logrus.TraceLevel) } } ``` Seems like JobLoggerLevel isn't set when initializing plan executor: ``` internal\app\run\runner.go executor := rr.NewPlanExecutor(plan) gitea.com\gitea\act@v0.251.1\pkg\runner\runner.go func (runner *runnerImpl) NewPlanExecutor(plan *model.Plan) common.Executor { ... return executor(common.WithJobErrorContainer(WithJobLogger(ctx, rc.Run.JobID, jobName, rc.Config, &rc.Masks, matrix))) ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
renovate/github.com-nektos-act-0.x
renovate/alpine-3.x
renovate/actions-setup-go-5.x
renovate/golang.org-x-term-0.x
v0.2.10
v0.2.9
v0.2.8
v0.2.7
v0.2.6
v0.2.5
v0.2.4
v0.2.3
v0.2.2
v0.2.1
v0.2.0
v0.1.8
v0.1.7
v0.1.6
v0.1.5
v0.1.4
v0.1.3
v0.1.2
v0.1.1
v0.1.0
v0.0.1
Labels
Clear labels   
kind
bug
Something is not working

  
kind
build

  
kind/compatible
  
kind
dependencies

  
kind
docs

  
kind
enhancement
New feature

  
kind
feature

  
kind
help wanted
Need some help

  
kind
proposal

  
kind
refactor

  
related
act
Related to act.

  
related
environment
Related to the environment.

  
related
exec

  
related
gitea
Related to Gitea.

  
related
workflow
Related to the workflow file or actions scripts.

  
reviewed
confirmed
confirmed issue

  
reviewed
duplicate
This issue or pull request already exists

  
reviewed
invalid
Something is wrong

  
reviewed
needs feedback

  
reviewed
wontfix
This won't be fixed

  
reviewed
workaround

No Label
kind
bug
kind
build
kind/compatible
kind
dependencies
kind
docs
kind
enhancement
kind
feature
kind
help wanted
kind
proposal
kind
refactor
related
act
related
environment
related
exec
related
gitea
related
workflow
reviewed
confirmed
reviewed
duplicate
reviewed
invalid
reviewed
needs feedback
reviewed
wontfix
reviewed
workaround
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/act_runner#409
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?