gitea/act_runner
61
107
Fork 80
Code Issues 139 Pull Requests 10 Actions 1 Releases 21 Activity

Runner doens't stop all containers after finishing #509

New Issue
Open
opened 2024-03-06 11:12:00 +00:00 by Zig1375 · 7 comments
Zig1375 commented 2024-03-06 11:12:00 +00:00
Copy Link

I have such a workflow:

name: Example

on:
  push:
    branches: [ "master" ]
  pull_request:
    branches: [ "master" ]
    
jobs:
  test:
    name: test
    runs-on: ubuntu-latest
    steps:
      - name : Checkout
        uses: actions/checkout@v4

      - name: Setup bun
        uses: oven-sh/setup-bun@v1

      - name: Start MongoDB
        uses: supercharge/mongodb-github-action@1.10.0
        with:
          mongodb-version: '7.0'
          mongodb-port: 27017
          mongodb-database: 'testdb'
          mongodb-replica-set: rs0

      - name: Install dependencies
        run: bun i

      - name: Run tests
        run: bun test --timeout 10000

After finishing the "test" job, the "mongo" container is still working and I cannot rerun the task. I have to stop and delete container before...
On the GitHub Actions the same script works as expected.

I have such a workflow: ```yaml name: Example on: push: branches: [ "master" ] pull_request: branches: [ "master" ] jobs: test: name: test runs-on: ubuntu-latest steps: - name : Checkout uses: actions/checkout@v4 - name: Setup bun uses: oven-sh/setup-bun@v1 - name: Start MongoDB uses: supercharge/mongodb-github-action@1.10.0 with: mongodb-version: '7.0' mongodb-port: 27017 mongodb-database: 'testdb' mongodb-replica-set: rs0 - name: Install dependencies run: bun i - name: Run tests run: bun test --timeout 10000 ``` After finishing the "test" job, the "mongo" container is still working and I cannot rerun the task. I have to stop and delete container before... On the GitHub Actions the same script works as expected.
Zettat123 added the
kind
bug
 label 2024-03-07 01:29:36 +00:00
Zettat123 commented 2024-03-07 08:08:04 +00:00
Member
Copy Link

I think the reason is that the supercharge/mongodb-github-action action creates a mongodb container that is not managed by act_runner. It's difficult for act_runner to remove the created mongodb container because act_runner cannot get the id of the container.

Maybe you could use services to create a mongodb container for test

I think the reason is that the `supercharge/mongodb-github-action` action [creates a mongodb container](https://github.com/supercharge/mongodb-github-action/blob/b0a1493307c4e9b82ed61f3858d606c5ff190c64/start-mongodb.sh#L96) that is not managed by act_runner. It's difficult for act_runner to remove the created mongodb container because act_runner cannot get the id of the container. Maybe you could use [services](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idservices) to create a mongodb container for test
Zig1375 commented 2024-03-07 09:49:58 +00:00
Author
Copy Link

I used the same action in GitHub Actions before we migrated to Gitea.
I'll try to use services... I was just surprised that act_runner works so differently than GitHub Actions...

I thought the act_runner should be able to get the container ID of a Docker, since the Docker is run by an action command:
https://github.com/supercharge/mongodb-github-action/blob/main/action.yml#L39-L41

So I thought runner runs the docker container from that command and it knows all info to remove it...
Am I wrong?

I used the same action in GitHub Actions before we migrated to Gitea. I'll try to use services... I was just surprised that act_runner works so differently than GitHub Actions... I thought the act_runner should be able to get the container ID of a Docker, since the Docker is run by an action command: https://github.com/supercharge/mongodb-github-action/blob/main/action.yml#L39-L41 So I thought runner runs the docker container from that command and it knows all info to remove it... Am I wrong?
Zettat123 commented 2024-03-07 10:00:17 +00:00
Member
Copy Link

I thought the act_runner should be able to get the container ID of a Docker, since the Docker is run by an action command:
https://github.com/supercharge/mongodb-github-action/blob/main/action.yml#L39-L41

Yes. This container(we'll call it "action_container" later) is created by act_runner and it can be removed by act_runner.

However, in my test, the mongodb container is a container that is created by "action_container". This means that the mongodb container and "action_container" are different containers. Since the mongodb container is not created by act_runner, act_runner cannot get its container ID.

> I thought the act_runner should be able to get the container ID of a Docker, since the Docker is run by an action command: https://github.com/supercharge/mongodb-github-action/blob/main/action.yml#L39-L41 Yes. This container(we'll call it "action_container" later) is created by act_runner and it can be removed by act_runner. However, in my test, the mongodb container is a container that is created by "action_container". This means that the mongodb container and "action_container" are different containers. Since the mongodb container is not created by act_runner, act_runner cannot get its container ID.
Zig1375 commented 2024-03-07 10:03:52 +00:00
Author
Copy Link

I see. Thank you for the clarification.

I see. Thank you for the clarification.
Zig1375 commented 2024-03-07 21:42:53 +00:00
Author
Copy Link

I think the reason is that the supercharge/mongodb-github-action action creates a mongodb container that is not managed by act_runner. It's difficult for act_runner to remove the created mongodb container because act_runner cannot get the id of the container.

Maybe you could use services to create a mongodb container for test

It seems services do not work: #511

> I think the reason is that the `supercharge/mongodb-github-action` action [creates a mongodb container](https://github.com/supercharge/mongodb-github-action/blob/b0a1493307c4e9b82ed61f3858d606c5ff190c64/start-mongodb.sh#L96) that is not managed by act_runner. It's difficult for act_runner to remove the created mongodb container because act_runner cannot get the id of the container. > > Maybe you could use [services](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idservices) to create a mongodb container for test It seems services do not work: https://gitea.com/gitea/act_runner/issues/511
feurer98 commented 2024-04-02 20:47:44 +00:00
Copy Link

i have a lot of networks standing after a job:
version from runner: v0.2.9
version gitea: 1.21.10

docker network prune -f
Deleted Networks:
GITEA-ACTIONS-TASK-582_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-584_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-594_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-579_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-590_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-592_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-571_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-569_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-572_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-576_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-581_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-583_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-564_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-574_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-575_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-577_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-578_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-586_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-580_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-588_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-589_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-591_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-567_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-570_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-568_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-585_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-587_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-573_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
i have a lot of networks standing after a job: version from runner: v0.2.9 version gitea: 1.21.10 ``` docker network prune -f Deleted Networks: GITEA-ACTIONS-TASK-582_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-584_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-594_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-579_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-590_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-592_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-571_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-569_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-572_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-576_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-581_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-583_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-564_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-574_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-575_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-577_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-578_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-586_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-580_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-588_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-589_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-591_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-567_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-570_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-568_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-585_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-587_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network GITEA-ACTIONS-TASK-573_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network ```
lunny commented 2024-04-03 02:01:11 +00:00
Owner
Copy Link

i have a lot of networks standing after a job:
version from runner: v0.2.9
version gitea: 1.21.10

docker network prune -f
Deleted Networks:
GITEA-ACTIONS-TASK-582_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-584_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-594_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-579_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-590_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-592_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-571_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-569_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-572_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-576_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-581_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-583_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-564_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-574_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-575_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-577_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-578_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-586_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-580_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-588_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-589_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-591_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-567_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-570_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-568_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-585_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-587_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network
GITEA-ACTIONS-TASK-573_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network

Thanks for the report. You can clean them manually. Most of them because of act runner crashed or the previous version's bug before v0.2.9

> i have a lot of networks standing after a job: > version from runner: v0.2.9 > version gitea: 1.21.10 > > ``` > docker network prune -f > Deleted Networks: > GITEA-ACTIONS-TASK-582_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-584_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-594_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-579_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-590_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-592_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-571_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-569_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-572_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-576_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-581_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-583_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-564_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-574_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-575_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-577_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-578_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-586_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-580_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-588_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-589_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-591_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-567_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-570_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-568_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-585_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-587_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > GITEA-ACTIONS-TASK-573_WORKFLOW-Build-And-Test-Python-Project_JOB-integration-test-integration-test-network > ``` > Thanks for the report. You can clean them manually. Most of them because of act runner crashed or the previous version's bug before v0.2.9
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
renovate/github.com-nektos-act-0.x
renovate/alpine-3.x
renovate/actions-setup-go-5.x
renovate/golang.org-x-term-0.x
v0.2.10
v0.2.9
v0.2.8
v0.2.7
v0.2.6
v0.2.5
v0.2.4
v0.2.3
v0.2.2
v0.2.1
v0.2.0
v0.1.8
v0.1.7
v0.1.6
v0.1.5
v0.1.4
v0.1.3
v0.1.2
v0.1.1
v0.1.0
v0.0.1
Labels
Clear labels   
kind
bug
Something is not working

  
kind
build

  
kind/compatible
  
kind
dependencies

  
kind
docs

  
kind
enhancement
New feature

  
kind
feature

  
kind
help wanted
Need some help

  
kind
proposal

  
kind
refactor

  
related
act
Related to act.

  
related
environment
Related to the environment.

  
related
exec

  
related
gitea
Related to Gitea.

  
related
workflow
Related to the workflow file or actions scripts.

  
reviewed
confirmed
confirmed issue

  
reviewed
duplicate
This issue or pull request already exists

  
reviewed
invalid
Something is wrong

  
reviewed
needs feedback

  
reviewed
wontfix
This won't be fixed

  
reviewed
workaround

No Label
kind
bug
kind
build
kind/compatible
kind
dependencies
kind
docs
kind
enhancement
kind
feature
kind
help wanted
kind
proposal
kind
refactor
related
act
related
environment
related
exec
related
gitea
related
workflow
reviewed
confirmed
reviewed
duplicate
reviewed
invalid
reviewed
needs feedback
reviewed
wontfix
reviewed
workaround
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/act_runner#509
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?