Local reusable workflows don't seem to work #80

New Issue

gjabell · 2023-03-26T09:27:14Z

gjabell commented

2023-03-26 09:27:14 +00:00

The following workflow fails on my personal instance:

.github/workflows/main.yaml

name: Main

on: [push]

jobs:
  build:
    uses: ./.github/workflows/build.yaml
    with:
      package: gitea

.github/workflows/build.yaml

name: Build

on:
  workflow_call:
    inputs:
      package:
        required: true

jobs:
  build:
    runs-on: ubuntu-22.04
    steps:
      - run: echo ${{ inputs.package }}

The logs for the build job:

default(version:main) received task 76 of job 70, be triggered by event: push
workflow prepared
evaluating expression 'success()'
expression 'success()' evaluated to 'true'

stat /galen/images/.github/workflows/build.yaml: no such file or directory

I'm guessing the repository isn't cloned by default so it can't fetch the workflow from the filesystem. I also tried changing the outer workflow to this:

name: Main

on: [push]

jobs:
  checkout:
    runs-on: ubuntu-22.04
    steps:
      - uses: actions/checkout@v3

  build:
    needs: checkout
    uses: ./.github/workflows/build.yaml
    with:
      package: gitea

To force a clone, but the reusable job doesn't seem to respect the dependency.

It seems like one option might be to treat all reusable actions as remote, as act seems to clone repos automatically in that case: https://gitea.com/gitea/act/src/branch/main/pkg/runner/reusable_workflow.go#L33

But looking further in that file it looks like it will at least need some tweaking as it only validates / downloads reusable actions that are on github: https://gitea.com/gitea/act/src/branch/main/pkg/runner/reusable_workflow.go#L127

The following workflow fails on my personal instance: `.github/workflows/main.yaml` ```yaml name: Main on: [push] jobs: build: uses: ./.github/workflows/build.yaml with: package: gitea ``` `.github/workflows/build.yaml` ```yaml name: Build on: workflow_call: inputs: package: required: true jobs: build: runs-on: ubuntu-22.04 steps: - run: echo ${{ inputs.package }} ``` The logs for the `build` job: ```bash default(version:main) received task 76 of job 70, be triggered by event: push workflow prepared evaluating expression 'success()' expression 'success()' evaluated to 'true' stat /galen/images/.github/workflows/build.yaml: no such file or directory ``` I'm guessing the repository isn't cloned by default so it can't fetch the workflow from the filesystem. I also tried changing the outer workflow to this: ```yaml name: Main on: [push] jobs: checkout: runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v3 build: needs: checkout uses: ./.github/workflows/build.yaml with: package: gitea ``` To force a clone, but the reusable job doesn't seem to respect the dependency. It seems like one option might be to treat all reusable actions as remote, as `act` seems to clone repos automatically in that case: https://gitea.com/gitea/act/src/branch/main/pkg/runner/reusable_workflow.go#L33 But looking further in that file it looks like it will at least need some tweaking as it only validates / downloads reusable actions that are on github: https://gitea.com/gitea/act/src/branch/main/pkg/runner/reusable_workflow.go#L127

wolfogre added the

kind

bug

label 2023-03-27 01:44:17 +00:00

Zettat123 commented

2023-03-27 07:41:51 +00:00

Now act clone repos only if the reusable workflow is remote. We need to improve the logic to support cloning repos for local reusable workflows.

https://gitea.com/gitea/act/src/branch/main/pkg/runner/reusable_workflow.go#L18

Now `act` clone repos only if the reusable workflow is remote. We need to improve the logic to support cloning repos for local reusable workflows. https://gitea.com/gitea/act/src/branch/main/pkg/runner/reusable_workflow.go#L18

Zettat123 referenced this issue from gitea/act

2023-03-27 10:32:09 +00:00

Support reusable workflow #34

wolfogre referenced this issue from a commit

2023-03-29 05:59:23 +00:00

Support reusable workflow (#34)

wolfogre closed this issue

2023-03-29 05:59:23 +00:00

Zettat123 referenced this issue

2023-04-06 06:59:50 +00:00

Support actions and workflows from private repos #102

nephatrine referenced this issue