Fix potential log panic #82

Zettat123 · 2023-03-27T09:18:42Z

Zettat123 commented

2023-03-27 09:18:42 +00:00

If a job uses a reusable workflow, the job's steps sequence will be empty.

But in log reporter, we don't check the length of r.state.Steps, which may cause panic.

if v, ok := entry.Data["stepNumber"]; ok {
	if v, ok := v.(int); ok {
		step = r.state.Steps[v]
	}
}

If a job uses a [reusable workflow](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-of-jobsjob_iduses), the job's steps sequence will be empty. But in log reporter, we don't check the length of `r.state.Steps`, which may cause panic. ``` go if v, ok := entry.Data["stepNumber"]; ok { if v, ok := v.(int); ok { step = r.state.Steps[v] } } ```

Zettat123 added 1 commit 2023-03-27 09:18:43 +00:00

check Steps length

check and test

Details

e1b8368d72

lunny commented

2023-03-27 12:35:49 +00:00

Should this be sent upstream?

lunny approved these changes 2023-03-27 12:36:03 +00:00

Zettat123 commented

2023-03-28 01:27:50 +00:00

Should this be sent upstream?

I don't think so. Because this bug only exists in the logger of act_runner, not in act.

> Should this be sent upstream? I don't think so. Because this bug only exists in the logger of `act_runner`, not in `act`.

wolfogre merged commit 1596e4b1fd into main

2023-03-28 03:49:10 +00:00

wolfogre referenced this issue from a commit

2023-03-28 03:49:10 +00:00

Fix potential log panic (#82)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/act_runner#82