gitea/act_runner
61
106
Fork 79
Code Issues 136 Pull Requests 9 Actions Releases 21 Activity

Add CLI flag for specifying the Docker image to use. #83

Merged
lunny merged 3 commits from :telackey/imageflag into main 2023-03-29 01:42:53 +00:00
Conversation 3 Commits 3 Files Changed 1 +3 -1
telackey commented 2023-03-27 18:04:09 +00:00
Contributor
Copy Link

Since the exec command does not use labels from .runner, there is no existing way to specify which Docker image to use for task execution.

This adds an --image flag for specifying it manually. The default remains node:16-bullseye.

Since the `exec` command does not use labels from `.runner`, there is no existing way to specify which Docker image to use for task execution. This adds an `--image` flag for specifying it manually. The default remains `node:16-bullseye`.
telackey added 1 commit 2023-03-27 18:04:10 +00:00
lunny commented 2023-03-28 00:13:24 +00:00
Owner
Copy Link

Oh, maybe we should still have labels containers mapping?

Oh, maybe we should still have labels containers mapping?
wolfogre commented 2023-03-28 03:46:43 +00:00
Owner
Copy Link

Oh, maybe we should still have labels containers mapping?

I don't think so, unlike daemon, a flag is enough for exec. The user may want to test the same job on different images, so it will be convenient to use a single flag.

> Oh, maybe we should still have labels containers mapping? I don't think so, unlike `daemon`, a flag is enough for `exec`. The user may want to test the same job on different images, so it will be convenient to use a single flag.
wolfogre approved these changes 2023-03-28 03:47:12 +00:00
lunny approved these changes 2023-03-28 15:29:02 +00:00
lunny added 1 commit 2023-03-28 15:29:19 +00:00
Merge branch 'main' into telackey/imageflag
All checks were successful
check and test
Details
424653a5e3
telackey added 1 commit 2023-03-28 20:54:42 +00:00
Merge branch 'main' into telackey/imageflag
All checks were successful
check and test
Details
b1a494f6cf
telackey commented 2023-03-29 01:12:55 +00:00
Author
Contributor
Copy Link

I do not have the approval to merge, but if someone else would like to do it, sounds good to me.

I do not have the approval to merge, but if someone else would like to do it, sounds good to me.
lunny merged commit 8eea12dd78 into main 2023-03-29 01:42:53 +00:00
a1012112796 added the
related
exec
 label 2023-05-16 09:15:25 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
wolfogre
lunny
Labels
Clear labels   
kind
bug
Something is not working

  
kind
build

  
kind/compatible
  
kind
dependencies

  
kind
docs

  
kind
enhancement
New feature

  
kind
feature

  
kind
help wanted
Need some help

  
kind
proposal

  
kind
refactor

  
related
act
Related to act.

  
related
environment
Related to the environment.

  
related
exec

  
related
gitea
Related to Gitea.

  
related
workflow
Related to the workflow file or actions scripts.

  
reviewed
confirmed
confirmed issue

  
reviewed
duplicate
This issue or pull request already exists

  
reviewed
invalid
Something is wrong

  
reviewed
needs feedback

  
reviewed
wontfix
This won't be fixed

  
reviewed
workaround

No Label
kind
bug
kind
build
kind/compatible
kind
dependencies
kind
docs
kind
enhancement
kind
feature
kind
help wanted
kind
proposal
kind
refactor
related
act
related
environment
related
exec
related
gitea
related
workflow
reviewed
confirmed
reviewed
duplicate
reviewed
invalid
reviewed
needs feedback
reviewed
wontfix
reviewed
workaround
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/act_runner#83
No description provided.
Delete Branch ":telackey/imageflag"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?