Inject version when building and report version to Gitea via log and header #43

sillyguodong · 2023-03-10T06:11:46Z

sillyguodong commented

2023-03-10 06:11:46 +00:00

close #42

Inject runner version when make build
After building, executing command line: ./act_runner -v or ./act_runner --version, the version of runner is printed.
In Actions UI:
Set request header in http client interceptor.

close #42 1. Inject runner version when `make build` After building, executing command line: `./act_runner -v` or `./act_runner --version`, the version of runner is printed. ![image](/attachments/e25efbd3-79b3-49a5-b93f-42646d42c707) 2. In `Actions` UI: ![image](/attachments/36c57470-2a1d-4796-9eb0-de3988ab88e1) 3. Set request header in http client interceptor.

image.png

158 KiB

image.png

25 KiB

sillyguodong added 2 commits 2023-03-10 06:11:47 +00:00

Inject runner version when building 6b809390a2

add runner version in reporter c304c673e6

techknowlogick requested changes 2023-03-10 06:17:47 +00:00

Dismissed

techknowlogick left a comment

Can you add ldflag to goreleaser config too?

sillyguodong added 1 commit 2023-03-10 06:47:51 +00:00

add ldflag in goreleaser config 16ae7100d5

techknowlogick dismissed techknowlogick’s review 2023-03-10 06:48:40 +00:00

Reason:

thanks :)

techknowlogick reviewed 2023-03-10 06:58:53 +00:00

cmd/cmd.go Outdated

						
				@ -12,6 +13,8 @@ import (

				const version = "0.1.5"

techknowlogick commented

2023-03-10 06:58:53 +00:00

What is this version used for?

What is this `version` used for?

👍 1

delvh approved these changes 2023-03-10 09:54:00 +00:00

delvh left a comment

Apart from @techknowlogick's comment LGTM.

sillyguodong reviewed 2023-03-10 10:25:14 +00:00

cmd/cmd.go Outdated

						
				@ -12,6 +13,8 @@ import (

				const version = "0.1.5"

sillyguodong commented

2023-03-10 07:08:20 +00:00

From the output of executing ./act_runner, it seems like version for act. I am not sure this version is useful, so I declare a new variable RunnerVersion. If this version is useless, i will use this to save the version of act_runner.

From the output of executing `./act_runner`, it seems like `version for act`. I am not sure this `version` is useful, so I declare a new variable `RunnerVersion`. If this `version` is useless, i will use this to save the version of `act_runner`.

wolfogre reviewed 2023-03-13 07:30:56 +00:00

cmd/cmd.go Outdated

						
				@ -12,6 +13,8 @@ import (

				const version = "0.1.5"

wolfogre commented

2023-03-13 07:30:49 +00:00

I'm pretty sure it's useless.

sillyguodong added 1 commit 2023-03-13 08:17:50 +00:00

use cmd.version to save runner verison, add request header 64cad20151

sillyguodong changed title from ~~WIP: Inject version when building and report version to Gitea via log and header~~ to Inject version when building and report version to Gitea via log and header

2023-03-13 08:19:05 +00:00

wolfogre approved these changes 2023-03-13 10:56:41 +00:00

wolfogre merged commit 0d71463662 into main

2023-03-13 10:57:35 +00:00

wolfogre referenced this issue from a commit

2023-03-13 10:57:36 +00:00

Inject version when building and report version to Gitea via log and header (#43)

sillyguodong referenced this pull request

2023-03-14 14:09:57 +00:00

Return runner version to Gitea and display runner version on Gitea side. #50

Sign in to join this conversation.

No reviewers