gitea
/
act_runner
42
36
Fork 34
Code Issues 44 Pull Requests 9 Actions 2 Releases 10 Activity

Inject version when building and report version to Gitea via log and header #43

Merged
wolfogre merged 4 commits from sillyguodong/act_runner:feature/issue_42 into main 2023-03-13 10:57:35 +00:00
Conversation 0 Commits 4 Files Changed 9
sillyguodong commented 2023-03-10 06:11:46 +00:00
Collaborator

close #42

  1. Inject runner version when make build
    After building, executing command line: ./act_runner -v or ./act_runner --version, the version of runner is printed.
    image

  2. In Actions UI:
    image

  3. Set request header in http client interceptor.

close #42 1. Inject runner version when `make build` After building, executing command line: `./act_runner -v` or `./act_runner --version`, the version of runner is printed. ![image](/attachments/e25efbd3-79b3-49a5-b93f-42646d42c707) 2. In `Actions` UI: ![image](/attachments/36c57470-2a1d-4796-9eb0-de3988ab88e1) 3. Set request header in http client interceptor.
image.png
158 KiB
image.png
25 KiB
sillyguodong added 2 commits 2023-03-10 06:11:47 +00:00
techknowlogick requested changes 2023-03-10 06:17:47 +00:00
Dismissed
techknowlogick left a comment
Owner

Can you add ldflag to goreleaser config too?

Can you add ldflag to goreleaser config too?
sillyguodong added 1 commit 2023-03-10 06:47:51 +00:00
techknowlogick dismissed techknowlogick’s review 2023-03-10 06:48:40 +00:00
Reason:
There is no content yet.
techknowlogick reviewed 2023-03-10 06:58:53 +00:00
cmd/cmd.go Outdated
@ -12,6 +13,8 @@ import (
const version = "0.1.5"
techknowlogick commented 2023-03-10 06:58:53 +00:00
Owner

What is this version used for?

What is this `version` used for?
👍 1
delvh approved these changes 2023-03-10 09:54:00 +00:00
delvh left a comment

Apart from @techknowlogick's comment LGTM.

Apart from @techknowlogick's comment LGTM.
sillyguodong reviewed 2023-03-10 10:25:14 +00:00
cmd/cmd.go Outdated
@ -12,6 +13,8 @@ import (
const version = "0.1.5"
sillyguodong commented 2023-03-10 07:08:20 +00:00
Poster
Collaborator

From the output of executing ./act_runner, it seems like version for act. I am not sure this version is useful, so I declare a new variable RunnerVersion. If this version is useless, i will use this to save the version of act_runner.

From the output of executing `./act_runner`, it seems like `version for act`. I am not sure this `version` is useful, so I declare a new variable `RunnerVersion`. If this `version` is useless, i will use this to save the version of `act_runner`.
wolfogre reviewed 2023-03-13 07:30:56 +00:00
cmd/cmd.go Outdated
@ -12,6 +13,8 @@ import (
const version = "0.1.5"
wolfogre commented 2023-03-13 07:30:49 +00:00
Owner

I'm pretty sure it's useless.

I'm pretty sure it's useless.
sillyguodong added 1 commit 2023-03-13 08:17:50 +00:00
sillyguodong changed title from WIP: Inject version when building and report version to Gitea via log and header to Inject version when building and report version to Gitea via log and header 2023-03-13 08:19:05 +00:00
wolfogre approved these changes 2023-03-13 10:56:41 +00:00
wolfogre merged commit 0d71463662 into main 2023-03-13 10:57:35 +00:00

Reviewers

delvh approved these changes 2023-03-10 09:54:00 +00:00
wolfogre approved these changes 2023-03-13 10:56:41 +00:00
Sign in to join this conversation.
Reviewers
Request review
No reviewers
delvh
wolfogre
Labels
Apply labels
Clear labels   
kind
bug
Something is not working   
kind
build
   
kind
dependencies
   
kind
docs
   
kind
enhancement
New feature   
kind
feature
   
kind
help wanted
Need some help   
kind
proposal
   
kind
refactor
  
related
act
Related to act.   
related
environment
Related to the environment.   
related
exec
   
related
gitea
Related to Gitea.   
related
workflow
Related to the workflow file or actions scripts.
  
reviewed
duplicate
This issue or pull request already exists   
reviewed
invalid
Something is wrong   
reviewed
needs feedback
   
reviewed
wontfix
This won't be fixed
No Label
kind
bug
kind
build
kind
dependencies
kind
docs
kind
enhancement
kind
feature
kind
help wanted
kind
proposal
kind
refactor
related
act
related
environment
related
exec
related
gitea
related
workflow
reviewed
duplicate
reviewed
invalid
reviewed
needs feedback
reviewed
wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/act_runner#43
There is no content yet.
Delete Branch "sillyguodong/act_runner:feature/issue_42"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?