gitea/act_runner
61
106
Fork 79
Code Issues 136 Pull Requests 9 Actions Releases 21 Activity

WIP: Add Dockerfile #55

Closed
lunny wants to merge 1 commits from lunny/act_runner:lunny/docker into main
pull from: lunny/act_runner:lunny/docker
merge into: gitea:main
Conversation 3 Commits 1 Files Changed 2 +37
lunny commented 2023-03-16 07:33:54 +00:00
Owner
Copy Link
No description provided.
lunny added 1 commit 2023-03-16 07:33:54 +00:00
Add Dockerfile
All checks were successful
check and test
Details
5b84fe1351
wolfogre commented 2023-03-16 07:38:16 +00:00
Owner
Copy Link

TBH, I think we should do this after #21

TBH, I think we should do this after https://gitea.com/gitea/act_runner/issues/21
lunny commented 2023-03-16 15:09:15 +00:00
Author
Owner
Copy Link

TBH, I think we should do this after #21

Why? I don't think we need a config file.

> TBH, I think we should do this after https://gitea.com/gitea/act_runner/issues/21 Why? I don't think we need a config file.
pj reviewed 2023-03-20 22:50:18 +00:00
docker.sh
@ -0,0 +1,7 @@
#!/bin/bash
pj commented 2023-03-20 22:50:18 +00:00
First-time contributor
Copy Link

you're using Alpine image and specifying bash as the script shell without installing bash in the image thonk

you're using Alpine image and specifying bash as the script shell without installing bash in the image *thonk*
pj reviewed 2023-03-20 22:51:49 +00:00
Dockerfile
@ -0,0 +22,4 @@
ENV INSTANCE ${INSTANCE:-}
ARG TOKEN
ENV TOKEN ${TOKEN:-}
pj commented 2023-03-20 22:51:49 +00:00
First-time contributor
Copy Link

ENV VAR VAL is old syntax, ENV VAR=VAL is recommended

  • for deployments like Docker Swarm or Podman which allow secrets, you should consider allowing using TOKEN_FILE
`ENV VAR VAL` is old syntax, `ENV VAR=VAL` is recommended + for deployments like Docker Swarm or Podman which allow secrets, you should consider allowing using `TOKEN_FILE`
wolfogre commented 2023-04-11 03:04:16 +00:00
Owner
Copy Link

Replaced by #84

Replaced by #84
wolfogre closed this pull request 2023-04-11 03:04:16 +00:00
Some checks are pending
check and test
Details
checks / check and test (pull_request)
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
kind
bug
Something is not working

  
kind
build

  
kind/compatible
  
kind
dependencies

  
kind
docs

  
kind
enhancement
New feature

  
kind
feature

  
kind
help wanted
Need some help

  
kind
proposal

  
kind
refactor

  
related
act
Related to act.

  
related
environment
Related to the environment.

  
related
exec

  
related
gitea
Related to Gitea.

  
related
workflow
Related to the workflow file or actions scripts.

  
reviewed
confirmed
confirmed issue

  
reviewed
duplicate
This issue or pull request already exists

  
reviewed
invalid
Something is wrong

  
reviewed
needs feedback

  
reviewed
wontfix
This won't be fixed

  
reviewed
workaround

No Label
kind
bug
kind
build
kind/compatible
kind
dependencies
kind
docs
kind
enhancement
kind
feature
kind
help wanted
kind
proposal
kind
refactor
related
act
related
environment
related
exec
related
gitea
related
workflow
reviewed
confirmed
reviewed
duplicate
reviewed
invalid
reviewed
needs feedback
reviewed
wontfix
reviewed
workaround
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/act_runner#55
No description provided.
Delete Branch "lunny/act_runner:lunny/docker"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?