gitea/actions-proto-def
43
6
Fork 4
Code Issues 1 Pull Requests Actions Releases 1 Activity

Missing task outputs in actions protocol #4

New Issue
Closed
opened 2022-12-08 11:27:57 +00:00 by ChristopherHX · 2 comments
ChristopherHX commented 2022-12-08 11:27:57 +00:00
Copy Link

A task (I think this means job in GitHub Actions) can send outputs back, however based on the TaskState Message this protocol can only store the success, failure etc. as result.

proto/runner/v1/messages.proto Line 82 in 9faf5cf879
message TaskState {

I see that the populated needs context can be send to the runner via

proto/runner/v1/messages.proto Line 76 in 9faf5cf879
optional google.protobuf.Struct context = 3; // See https://docs.github.com/en/actions/learn-github-actions/contexts#github-context .
, but there seem to be no way for send outputs back to gitea.

Official GitHub Documentation for job outputs:

nektos/act, currently evaluates job outputs inplace in

pkg/model/workflow.go Line 116 in 7920109e89
Outputs map[string]string `yaml:"outputs"`
. This is probably a place, which needs refactoring to not update the job model object.

This is only relevant for an internal runner protocol for gitea. External CI would maintain this information on it's own, because task outputs are not visible in the UI.

A task (I think this means job in GitHub Actions) can send outputs back, however based on the TaskState Message this protocol can only store the success, failure etc. as result. https://gitea.com/gitea/actions-proto-def/src/commit/9faf5cf8790917ef06b1cb62560212f3fd663793/proto/runner/v1/messages.proto#L82 I see that the populated needs context can be send to the runner via https://gitea.com/gitea/actions-proto-def/src/commit/9faf5cf8790917ef06b1cb62560212f3fd663793/proto/runner/v1/messages.proto#L76, but there seem to be no way for send outputs back to gitea. Official GitHub Documentation for job outputs: - https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idoutputs nektos/act, currently evaluates job outputs inplace in https://gitea.com/gitea/act/src/commit/7920109e895138b6db7825f80241bc17192e07ad/pkg/model/workflow.go#L116. This is probably a place, which needs refactoring to not update the job model object. _This is only relevant for an internal runner protocol for gitea. External CI would maintain this information on it's own, because task outputs are not visible in the UI._
wolfogre commented 2022-12-09 03:51:46 +00:00
Owner
Copy Link

Yes, you're right, we overlooked that part.

I think it's necessary to add support for outputs, but you know, the current PR is too large, I plan to start a new PR to do it later, what do you think?

And I believe you're an expert at GitHub actions, could you please don't reject if I have some questions to ask you in the future? ?

Yes, you're right, we overlooked that part. I think it's necessary to add support for `outputs`, but you know, the current PR is too large, I plan to start a new PR to do it later, what do you think? And I believe you're an expert at GitHub actions, could you please don't reject if I have some questions to ask you in the future? ?
wolfogre added the
enhancement
 label 2022-12-09 03:55:17 +00:00
ChristopherHX commented 2022-12-09 08:20:17 +00:00
Author
Copy Link

Yes splitting the server side PR is a good idea. This issue is actually only for the protocol, the server and runner side is more complex.

Feel free to ask me.

Yes splitting the server side PR is a good idea. This issue is actually only for the protocol, the server and runner side is more complex. Feel free to ask me.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
v0.4.0
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
proposal

   
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
proposal
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/actions-proto-def#4
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?