Revamp themes section #60

Merged
lunny merged 3 commits from xeruf/awesome-gitea:master into master 2021-10-25 02:34:43 +00:00
Contributor
  • Spacemacs-inspired theme is unfortunately broken in 1.14
  • Create order to ease finding a desired theme
  • Removes unnecessary mentions of Gitea (this list is obviously about Gitea)
- Spacemacs-inspired theme is unfortunately broken in 1.14 - Create order to ease finding a desired theme - Removes unnecessary mentions of Gitea (this list is obviously about Gitea)
xeruf added 1 commit 2021-10-12 19:56:16 +00:00
0ba28e0008 Revamp themes section
- Spacemacs-inspired theme is unfortunately broken in 1.14
- Create order to ease finding a desired theme
pat-s reviewed 2021-10-12 21:10:40 +00:00
README.md Outdated
@ -156,1 +145,3 @@
* [theme.park](https://github.com/gilbN/theme.park/wiki/Gitea) - A theme suite for Gitea.
* [Modern](https://codeberg.org/Freeplay/CSS-Styles/src/branch/main/Gitea#gitea-modern) - Changes the layout for a more modern look. Usable with other themes that only change colors.
* [theme.park](https://docs.theme-park.dev/themes/gitea) - A theme suite that includes Gitea
* [Adaptive GitHub](https://github.com/pat-s/gitea-github-theme) - GitHub-inspired Gitea theme with dark and light styles
Member

Thanks.

I am not sure if all theme authors would agree to such naming changes - being the author of the gitea-github-theme I'd prefer to stay with the previous name rather than calling it "Adaptive GitHub".

I agree the "Gitea" repetitions might be worthless here but outside of this list the Gitea term is important within the standalone repos.

Thanks. I am not sure if all theme authors would agree to such naming changes - being the author of the `gitea-github-theme` I'd prefer to stay with the previous name rather than calling it "Adaptive GitHub". I agree the "Gitea" repetitions might be worthless here but outside of this list the Gitea term is important within the standalone repos.
Author
Contributor

Yes, It is important within the standalone repos, but we do not have to label the themes as they are in the repos

This list should be user-friendly with expressive names - having two themes named "Github" really does not help (and adding a 2 also does not fit with the original repo), and one distinguisher is that yours is adaptive in the sense that it has light and dark schemes.

Yes, It is important within the standalone repos, but we do not have to label the themes as they are in the repos This list should be user-friendly with expressive names - having two themes named "Github" really does not help (and adding a 2 also does not fit with the original repo), and one distinguisher is that yours is adaptive in the sense that it has light and dark schemes.
Member

Yes, It is important within the standalone repos, but we do not have to label the themes as they are in the repos

We do not but we should maybe check back with the authors instead of changing the names substantially.

This list should be user-friendly with expressive names - having two themes named "Github" really does not help (and adding a 2 also does not fit with the original repo), and one distinguisher is that yours is adaptive in the sense that it has light and dark schemes.

Yes, adding a "2" is also not a super solution but closer to the upstream name than putting a new word in front of it.

I am not sure if we should put that opionions on theme names here.

OTOH it is also not really worth spending so much time to discuss this as it's just a list. We should use this time and energy discussing the general implementation of user-defined themes and the user instructions.

So if you have a really strong opinion that this is better than before, I won't block it but maybe my arguments can be considered in some way :)

> Yes, It is important within the standalone repos, but we do not have to label the themes as they are in the repos We do not but we should maybe check back with the authors instead of changing the names substantially. > This list should be user-friendly with expressive names - having two themes named "Github" really does not help (and adding a 2 also does not fit with the original repo), and one distinguisher is that yours is adaptive in the sense that it has light and dark schemes. Yes, adding a "2" is also not a super solution but closer to the upstream name than putting a new word in front of it. I am not sure if we should put that opionions on theme names here. OTOH it is also not really worth spending so much time to discuss this as it's just a list. We should use this time and energy discussing the general implementation of user-defined themes and the user instructions. So if you have a really strong opinion that this is better than before, I won't block it but maybe my arguments can be considered in some way :)
lunny requested changes 2021-10-17 11:44:31 +00:00
lunny left a comment
Owner
per https://gitea.com/gitea/awesome-gitea/pulls/60#issuecomment-593416
Contributor

Maybe making it a table with screenshots if possible?

Maybe making it a table with screenshots if possible?
xeruf added 1 commit 2021-10-23 13:38:35 +00:00
xeruf force-pushed master from d96194054a to 1c1625d7d3 2021-10-23 13:45:34 +00:00 Compare
Member

@xeruf Thanks, I think using the repo slugs is a good unbiased solution. Maybe we should do this for all even?

@freeplay
Could be nice but it's quite some work - do you want to help here?

@xeruf Thanks, I think using the repo slugs is a good unbiased solution. Maybe we should do this for all even? @freeplay Could be nice but it's quite some work - do you want to help here?
Author
Contributor

@freeplay nice idea, but gitea does not seem to support markdown tables by default, see https://gitea.com/xeruf/awesome-gitea/src/branch/themes-table

Anyways, should be updated to your liking now @pat-s :)

@freeplay nice idea, but gitea does not seem to support markdown tables by default, see https://gitea.com/xeruf/awesome-gitea/src/branch/themes-table Anyways, should be updated to your liking now @pat-s :)
xeruf requested review from lunny 2021-10-23 13:47:14 +00:00
xeruf added 1 commit 2021-10-23 13:49:55 +00:00
Author
Contributor

Now also supercedes #56 :)

Now also supercedes #56 :)
lunny approved these changes 2021-10-24 08:05:15 +00:00
pat-s approved these changes 2021-10-24 11:57:47 +00:00
lunny merged commit c8a2f7c2af into master 2021-10-25 02:34:43 +00:00
lunny referenced this issue from a commit 2021-10-25 02:34:44 +00:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/awesome-gitea#60
No description provided.