sometimes the PR fixes several bugs, and we don't always notice at the time of creation #14

New Issue

6543 · 2019-10-18T18:29:58Z

6543 commented

2019-10-18 18:29:58 +00:00

From Discord

PersonA
  @PersonB sometimes the PR fixes several bugs, and we don't always notice at the time of 
  creation. It will be very error prone (prone to errors?).
 
PersonB
  Another thing is whether we should try to follow the angular convention?
  @PersonA yeah I guess so.
 
PesonA
  If we change the way we make the changelog, we should at least clarify that at the 
  top of the document.
 
PersonC
  Relevant https://github.com/go-gitea/gitea/issues/6711
  Notably, Gitlab's approach would make this simple by including an issue_fixed or 
  related field.
 
PersonA
  Or the gitea changelog tool could check for issues marked as closed by the PRs. 
  :rolling_eyes:

From Discord ```chat PersonA @PersonB sometimes the PR fixes several bugs, and we don't always notice at the time of creation. It will be very error prone (prone to errors?). PersonB Another thing is whether we should try to follow the angular convention? @PersonA yeah I guess so. PesonA If we change the way we make the changelog, we should at least clarify that at the top of the document. PersonC Relevant https://github.com/go-gitea/gitea/issues/6711 Notably, Gitlab's approach would make this simple by including an issue_fixed or related field. PersonA Or the gitea changelog tool could check for issues marked as closed by the PRs. :rolling_eyes: ```

guillep2k commented

2019-10-18 20:11:18 +00:00

There's a PR I'm working on that will link which issues are closed from the comments on the PR (i.e. in addition to the commit messages). I think that should help.

👍 3

6543 added the

enhancement

label 2020-01-26 03:54:16 +00:00

Sign in to join this conversation.