gitea/changelog
43
16
Fork 11
Code Issues 11 Pull Requests 1 Actions Releases 5 Wiki Activity

Changelog Overhaul 2 #19

Merged
zeripath merged 25 commits from jolheiser/changelog:gitea-sdk into master 2020-01-24 16:30:19 +00:00
Conversation 9 Commits 25 Files Changed 18 +663 -239
jolheiser commented 2020-01-13 21:31:16 +00:00
Owner
Copy Link

Resolves #4
Continues #6
Resolves #15
Resolves #25

This PR:

  • Branches out services (GitHub and Gitea)
  • Allows users to pass in a token (for private repos/instances)
  • Allows users to generate a details list
  • Allows users to filter out PRs based on minimum index
Resolves #4 Continues #6 Resolves #15 Resolves #25 This PR: * Branches out services (GitHub and Gitea) * Allows users to pass in a token (for private repos/instances) * Allows users to generate a details list * Allows users to filter out PRs based on minimum index
:gitea: 1
jolheiser added the
enhancement
 label 2020-01-13 21:31:16 +00:00
6543 added a new dependency 2020-01-14 16:52:41 +00:00
gitea/go-sdk#219 - Fix ListRepoPullRequests
6543 removed a dependency 2020-01-14 16:52:47 +00:00
gitea/go-sdk#219 - Fix ListRepoPullRequests
6543 added a new dependency 2020-01-14 16:53:04 +00:00
gitea/go-sdk#219 - Fix ListRepoPullRequests
6543 commented 2020-01-17 06:24:42 +00:00
Owner
Copy Link

@jolheiser fix is merged

@jolheiser fix is merged
jolheiser commented 2020-01-17 18:19:14 +00:00
Author
Owner
Copy Link

This is ready for review, with one more caveat. Currently the SDK doesn't allow us to search milestones by anything other than open state, so this tool can only find open milestones until that is fixed.

This is ready for review, with one more caveat. Currently the SDK doesn't allow us to search milestones by anything other than `open` state, so this tool can only find open milestones until that is fixed.
jolheiser changed title from WIP: Gitea Service to Gitea Service 2020-01-17 18:21:54 +00:00
6543 commented 2020-01-17 19:02:30 +00:00
Owner
Copy Link

what !?! - I'll look at this!

what !?! - I'll look at this!
6543 commented 2020-01-17 19:58:32 +00:00
Owner
Copy Link

@jolheiser for milestones -> gitea/go-sdk#230

@jolheiser for milestones -> https://gitea.com/gitea/go-sdk/issues/230
jolheiser changed title from Gitea Service to Changelog Overhaul 2 2020-01-22 19:54:52 +00:00
6543 reviewed 2020-01-22 23:42:28 +00:00
Dismissed
service/gitea.go
@ -0,0 +35,4 @@
tagURL := fmt.Sprintf("## [%s](%s/%s/%s/pulls?q=&type=all&state=closed&milestone=%d) - %s", ge.Milestone, ge.BaseURL, ge.Owner, ge.Repo, milestoneID, time.Now().Format("2006-01-02"))
p := 1
// https://github.com/go-gitea/gitea/blob/d92781bf941972761177ac9e07441f8893758fd3/models/repo.go#L63
6543 commented 2020-01-22 23:42:28 +00:00
Owner
Copy Link

can you write the reason instead of linking to source code?

can you write the reason instead of linking to source code?
jolheiser commented 2020-01-23 01:55:10 +00:00
Author
Owner
Copy Link

Done.

Done.
6543 approved these changes 2020-01-23 02:49:43 +00:00
Dismissed
lunny reviewed 2020-01-23 02:50:23 +00:00
Dismissed
service/github_test.go Outdated
@ -0,0 +1,34 @@
package service
lunny commented 2020-01-23 02:50:23 +00:00
Owner
Copy Link

copyright head

copyright head
lunny reviewed 2020-01-23 02:51:05 +00:00
Dismissed
service/service_test.go Outdated
@ -0,0 +1,10 @@
package service
lunny commented 2020-01-23 02:51:05 +00:00
Owner
Copy Link

copyright head

copyright head
6543 reviewed 2020-01-23 02:53:13 +00:00
Dismissed
main.go
@ -4,10 +4,14 @@
6543 commented 2020-01-23 02:53:13 +00:00
Owner
Copy Link

copyright head ...

copyright head ...
jolheiser commented 2020-01-23 04:11:04 +00:00
Author
Owner
Copy Link

There is already a copyright here.

There is already a copyright here.
6543 reviewed 2020-01-23 02:53:34 +00:00
Dismissed
config/config_default.go
6543 commented 2020-01-23 02:53:34 +00:00
Owner
Copy Link

copyright head

copyright head
6543 reviewed 2020-01-23 02:54:07 +00:00
Dismissed
changelog.example.yml
@ -1,6 +1,12 @@
# The full repository name
6543 commented 2020-01-23 02:54:07 +00:00
Owner
Copy Link

copyright head ? @lunny

copyright head ? @lunny
6543 reviewed 2020-01-23 02:54:17 +00:00
Dismissed
changelog.example.go
@ -10,8 +10,8 @@ import (
6543 commented 2020-01-23 02:54:17 +00:00
Owner
Copy Link

copyright head ? @lunny

copyright head ? @lunny
guillep2k reviewed 2020-01-23 02:58:38 +00:00
Dismissed
changelog.example.yml Outdated
@ -4,0 +5,4 @@
service: github
# Base URL for Gitea instance if using gitea service type
base-url: https://gitea.com
guillep2k commented 2020-01-23 02:42:02 +00:00
Member
Copy Link

If the example base-url points to gitea.com, shouldn't the service match it with gitea instead of github?

If the example `base-url` points to gitea.com, shouldn't the service match it with `gitea` instead of `github`?
jolheiser commented 2020-01-23 04:00:16 +00:00
Author
Owner
Copy Link

Should we really attempt to infer service type based on this URL?

Should we really attempt to infer service type based on this URL?
guillep2k commented 2020-01-23 04:11:55 +00:00
Member
Copy Link

I didn't mean it like that. I thought this file would make more sense either like:

# Service type (gitea or github)
service: gitea

# Base URL for Gitea instance if using gitea service type
base-url: https://gitea.com

or

# Service type (gitea or github)
service: github

# Base URL for Gitea instance if using GitHub service type
base-url: https://github.com

Currently it looks mixed up: service says github but URL is gitea.com (if it's intentional, I'm missing the point)

I didn't mean it like that. I thought this file would make more sense either like: ``` # Service type (gitea or github) service: gitea # Base URL for Gitea instance if using gitea service type base-url: https://gitea.com ``` or ``` # Service type (gitea or github) service: github # Base URL for Gitea instance if using GitHub service type base-url: https://github.com ``` Currently it looks mixed up: service says `github` but URL is `gitea.com` (if it's intentional, I'm missing the point)
jolheiser commented 2020-01-23 04:14:11 +00:00
Author
Owner
Copy Link

Ah, no that's okay.
The reason I did it this way is because https://gitea.com is the default gitea instance, yet currently we are still primarily using GitHub, so I left the service set as such.
No need to set a base-url for GitHub because it will never change.

Ah, no that's okay. The reason I did it this way is because `https://gitea.com` is the default gitea instance, yet currently we are still primarily using GitHub, so I left the service set as such. No need to set a base-url for GitHub because it will never change.
guillep2k commented 2020-01-23 07:08:43 +00:00
Member
Copy Link

It's only a bit confusing, that's all. Being the example file...

It's only a bit confusing, that's all. Being the example file...
jolheiser commented 2020-01-23 15:30:56 +00:00
Author
Owner
Copy Link

Yeah, fair enough. Do you think it would make more sense to leave base-url blank for the time being?

Yeah, fair enough. Do you think it would make more sense to leave `base-url` blank for the time being?
guillep2k commented 2020-01-23 16:46:16 +00:00
Member
Copy Link

I'd use Gitea's for both parameters and add a comment about base-url not being required in the case of GitHub. Having said that, I would honor any base-url setting, even in the case of GitHub. We never know, maybe there's another repository hosting service that implements GitHub's API that we never knew about, or maybe GitHub allows private domains for corporate accounts, etc.

Ideally, I'd make base-url optional in both cases (GitHub and Gitea), but always honor its value if present and not empty.

I'd use Gitea's for both parameters and add a comment about `base-url` not being required in the case of GitHub. Having said that, I _would_ honor any `base-url` setting, even in the case of GitHub. We never know, maybe there's another repository hosting service that implements GitHub's API that we never knew about, or maybe GitHub allows private domains for corporate accounts, etc. Ideally, I'd make `base-url` optional in _both cases_ (GitHub and Gitea), but always honor its value if present and not empty.
cmd/generate.go Outdated
@ -0,0 +15,4 @@
var Generate = &cli.Command{
Name: "generate",
Usage: "generate changelog",
guillep2k commented 2020-01-23 02:45:31 +00:00
Member
Copy Link

If changelog here is a parameter, it's customary to use some indication (e.g. generate {changelog}). In *nix style, curly braces mean required parameters and square brackets mean optional. If you prefer, you could use another style like generate "changelog".

If `changelog` here is a parameter, it's customary to use some indication (e.g. `generate {changelog}`). In *nix style, curly braces mean required parameters and square brackets mean optional. If you prefer, you could use another style like `generate "changelog"`.
jolheiser commented 2020-01-23 04:00:39 +00:00
Author
Owner
Copy Link

I can change it, this isn't a parameter.

I can change it, this isn't a parameter.
guillep2k commented 2020-01-23 04:06:38 +00:00
Member
Copy Link

I was wondering about that. No need to change, then. ?

I was wondering about that. No need to change, then. ?
config/config_default.go
@ -0,0 +8,4 @@
service: github
# Base URL for Gitea instance if using gitea service type
base-url: https://gitea.com
guillep2k commented 2020-01-23 02:58:13 +00:00
Member
Copy Link

Same concern here

Same concern here
jolheiser commented 2020-01-23 04:16:09 +00:00
Author
Owner
Copy Link

All copyrights should be updated, except the example config because I don't think there's any reason to?

All copyrights should be updated, except the example config because I don't think there's any reason to?
👍 1
guillep2k approved these changes 2020-01-23 07:09:13 +00:00
Dismissed
6543 approved these changes 2020-01-23 08:00:53 +00:00
Dismissed
6543 commented 2020-01-23 16:49:15 +00:00
Owner
Copy Link

go test -race go: code.gitea.io/sdk/gitea@v0.0.0-20200116035226-b24cfd841cda: Get https://goproxy.cn/code.gitea.io/sdk/gitea/@v/v0.0.0-20200116035226-b24cfd841cda.mod: No such domain

???

`go test -race go: code.gitea.io/sdk/gitea@v0.0.0-20200116035226-b24cfd841cda: Get https://goproxy.cn/code.gitea.io/sdk/gitea/@v/v0.0.0-20200116035226-b24cfd841cda.mod: No such domain` ???
6543 commented 2020-01-23 17:03:59 +00:00
Owner
Copy Link

@jolheiser tested my fix with your PR: https://drone.gitea.com/gitea/changelog/9/1/2

works :)

fix is here: #26

@jolheiser tested my fix with your PR: https://drone.gitea.com/gitea/changelog/9/1/2 works :) fix is here: #26
jolheiser commented 2020-01-23 17:28:36 +00:00
Author
Owner
Copy Link

@6543 It worked with my latest push. It's sometimes just a luck thing.

@6543 It worked with my latest push. It's sometimes just a luck thing.
6543 commented 2020-01-23 17:43:29 +00:00
Owner
Copy Link

@jolheiser I thin #26 is still a Improvement

@jolheiser I thin #26 is still a Improvement
guillep2k approved these changes 2020-01-23 18:37:53 +00:00
Dismissed
zeripath closed this pull request 2020-01-24 16:30:18 +00:00
jolheiser deleted branch gitea-sdk 2020-01-24 17:06:08 +00:00
6543 added this to the v0.1.0 milestone 2020-01-26 03:58:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
breaking

   
bug

   
build

Changes to builds

  
duplicate

   
enhancement

   
feature

   
help wanted

   
invalid
  
lgtm
done

  
lgtm
need 1

  
question

   
skip-changelog

   
wontfix
No Label
breaking
bug
build
duplicate
enhancement
feature
help wanted
invalid
lgtm
done
lgtm
need 1
question
skip-changelog
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.1.0
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on
#219 Fix ListRepoPullRequests
gitea/go-sdk
Reference: gitea/changelog#19
No description provided.
Delete Branch "jolheiser/changelog:gitea-sdk"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?