gitea/changelog
43
16
Fork 11
Code Issues 11 Pull Requests 1 Actions Releases 5 Wiki Activity

Add flag to specify git tag #58

Merged
6543 merged 1 commits from 6543/gitea_changelog_tool:tag-flag into master 2022-03-13 02:33:03 +00:00
Conversation 0 Commits 1 Files Changed 8 +23 -7
6543 commented 2022-03-09 01:34:20 +00:00
Owner
Copy Link

close #57

close #57
6543 added 1 commit 2022-03-09 01:34:20 +00:00
add flag to specify git tag
All checks were successful
continuous-integration/drone/pr Build is passing
Details
30ae24bd56
zeripath approved these changes 2022-03-10 08:20:44 +00:00
noerw approved these changes 2022-03-10 10:42:41 +00:00
noerw left a comment
Member
Copy Link

just one nit

just one nit
service/service.go
@ -15,1 +15,3 @@
func New(serviceType, repo, baseURL, milestone, token string, issues bool) (Service, error) {
func New(serviceType, repo, baseURL, milestone, tag, token string, issues bool) (Service, error) {
if len(tag) == 0 {
tag = milestone
noerw commented 2022-03-10 10:42:00 +00:00
Member
Copy Link

could you add a comment explaining / warning that we default tag to milestone?

could you add a comment explaining / warning that we default tag to milestone?
6543 commented 2022-03-13 00:59:03 +00:00
Author
Owner
Copy Link

It's already in the flag description, should I print to stdout?

@noerw

It's already in the flag description, should I print to stdout? @noerw
noerw commented 2022-03-13 01:14:59 +00:00
Member
Copy Link

ah i see, never mind then.

ah i see, never mind then.
noerw marked this conversation as resolved
6543 merged commit f3ee0e5726 into master 2022-03-13 02:33:03 +00:00
6543 deleted branch tag-flag 2022-03-13 02:33:04 +00:00
6543 added this to the v0.3.0 milestone 2022-03-13 02:33:15 +00:00
6543 added the
feature
 label 2022-03-13 02:33:21 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
zeripath
noerw
Labels
Clear labels   
breaking

   
bug

   
build

Changes to builds

  
duplicate

   
enhancement

   
feature

   
help wanted

   
invalid
  
lgtm
done

  
lgtm
need 1

  
question

   
skip-changelog

   
wontfix
No Label
breaking
bug
build
duplicate
enhancement
feature
help wanted
invalid
lgtm
done
lgtm
need 1
question
skip-changelog
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.3.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/changelog#58
No description provided.
Delete Branch "6543/gitea_changelog_tool:tag-flag"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?