Priorize groups by order #61

New Issue

6543 · 2022-06-18T18:59:31Z

6543 commented

2022-06-18 18:59:31 +00:00

at the moment a simple map[] is used, we should see the group list as priorized list since you can have lable overlap.

at the moment we could call it "unpredicted" behaviour!!!

https://github.com/go-gitea/gitea/pull/20023#issuecomment-1159518632

at the moment a simple map[] is used, we should see the group list as priorized list since you can have lable overlap. at the moment we could call it "unpredicted" behaviour!!! https://github.com/go-gitea/gitea/pull/20023#issuecomment-1159518632

lunny commented

2022-06-19 03:11:55 +00:00

I have checked the code, Group is a slice and PR is also a slice which could be sort. I don't know what did you mean a simple map[] is used.

I have checked the code, `Group` is a slice and `PR` is also a slice which could be sort. I don't know what did you mean `a simple map[] is used`.

6543 commented

2022-06-19 19:18:12 +00:00

https://gitea.com/gitea/changelog/src/branch/master/cmd/generate.go#L24

https://gitea.com/gitea/changelog/src/branch/master/cmd/generate.go#L106-L108

we need am more inteligent function ...

https://gitea.com/gitea/changelog/src/branch/master/cmd/generate.go#L24 https://gitea.com/gitea/changelog/src/branch/master/cmd/generate.go#L106-L108 we need am more inteligent function ...

jolheiser commented

2022-06-19 19:51:26 +00:00

A map is used, however the issue is not the map, but that the PR labels are only looped until first match.
The original idea was that labels wouldn't be overlapping.

A fix may be as simple as ordering PR labels by weight prior to looping.

A map is used, however the issue is not the map, but that the PR labels are only looped until first match. The original idea was that labels wouldn't be overlapping. A fix may be as simple as ordering PR labels by weight prior to looping.

6543 commented

2022-06-19 20:37:42 +00:00

i would not weight labels but see the order of group as priority

so if

# Changelog groups and which labeled PRs to add to each group
groups:
  -
    name: FEATURES
    labels:
      - feature
  -
    name: BUGFIXES
    labels:
      - bug

and a pull has both labels, it is in the feature group

i would not weight labels but see the order of group as priority so if ```yml # Changelog groups and which labeled PRs to add to each group groups: - name: FEATURES labels: - feature - name: BUGFIXES labels: - bug ``` and a pull has both labels, it is in the feature group

jolheiser referenced a pull request that will close this issue

2022-06-20 18:40:22 +00:00

Updates and priority changes #62

lunny closed this issue

2022-06-22 01:27:25 +00:00

Sign in to join this conversation.