Gitea Service: Use single release page (>= 1.12) #47

6543 · 2020-08-07T12:54:37Z

6543 commented

2020-08-07 12:54:37 +00:00

close #42

6543 added this to the v0.2.0 milestone 2020-08-07 12:54:37 +00:00

6543 added the

enhancement

label 2020-08-07 12:54:37 +00:00

6543 added 1 commit 2020-08-07 12:54:39 +00:00

gitea >= 1.12 has single release page

continuous-integration/drone/pr Build is failing

Details

e12449228d

jaqra approved these changes 2020-08-07 13:04:53 +00:00

Dismissed

service/gitea.go Outdated

						
				@ -38,6 +38,9 @@ func (ge *Gitea) Generate() (string, []Entry, error) {

					}

					tagURL := fmt.Sprintf("## [%s](%s/%s/%s/%s?q=&type=all&state=closed&milestone=%d) - %s", ge.Milestone, ge.BaseURL, ge.Owner, ge.Repo, from, milestoneID, time.Now().Format("2006-01-02"))

					if err := client.CheckServerVersionConstraint(">=1.12"); err == nil {

jaqra commented

2020-08-07 13:03:46 +00:00

Should also check if changelog from pulls. I mean !(ge.Issues)

Should also check if changelog from pulls. I mean `!(ge.Issues)`

jaqra commented

2020-08-07 13:05:34 +00:00

Sorry. Missclick. did not want to approve

6543 added 1 commit 2020-08-07 13:09:26 +00:00

try to fix lint

continuous-integration/drone/pr Build is passing

Details

a99ee8917e

6543 commented

2020-08-07 13:13:53 +00:00

Should also check if changelog from pulls. I mean !(ge.Issues)

@jaqra and why?

> Should also check if changelog from pulls. I mean `!(ge.Issues)` @jaqra and why?

jolheiser reviewed 2020-08-07 13:30:38 +00:00

Dismissed

service/gitea.go Outdated

						
				@ -87,0 +88,4 @@

					if err := c.CheckServerVersionConstraint(">=1.12"); err == nil {

						return fmt.Sprintf("## [%s](%s/%s/%s/releases/tag/%s) - %s", mileName, baseURL, owner, repo, mileName, time.Now().Format("2006-01-02"))

					}

					return fmt.Sprintf("## [%s](%s/%s/%s/%s?q=&type=all&state=closed&milestone=%d) - %s", mileName, baseURL, owner, repo, from, mileID, time.Now().Format("2006-01-02"))