Use io reader for GetFormatPatch #105
No reviewers
Labels
No Label
in progress
kind/bug
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/security
kind/testing
kind/translation
kind/ui
lgtm/done
lgtm/need 1
lgtm/need 2
priority/critical
priority/low
priority/maybe
priority/medium
refactor
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
status/blocked
status/needs-feedback
status/wip
No Milestone
No Assignees
1 Participants
No due date set.
Dependencies
No dependencies set.
Reference: gitea/git#105
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "unknown repository"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Author: @lunny
As title.
Author: @strk
How about naming the new function GetFormatPatchReader and keep the old signature ?
Also I think it would be worth adding a GetPatchReader to go with the GetPatch one, and test all of them.
Author: @lunny
@strk GetFormatPatch is unnecessary I think.
Author: @strk
It would be for consistency with GetPatch. Consistency in naming is important, IMHO, and you don't want to change API of GetPatch.
Author: @strk
but ok if you just want to rename to GetFormatPatchReader and not provide GetFormatPatch...
Author: @strk
Why did you not rename the method ?
Note that Macaron wants a ReadSeeker, so the Reader from this changed method is not good to be passed to ServeContent (lacks Seek)
Author: @strk
nevermind, fixed via io.Copy as suggested on IRC