Simplify sha1 functions #111

lunny · 2018-02-10T06:54:36Z

lunny commented

2018-02-10 06:54:36 +00:00

Author: @ethantkoenig

Some simplifications to prevent wheel re-invention:

Use hex.EncodeString(..) instead of manually hex encoding
- This is likely to be faster, since we don't have to allocate a byte array containg 012..ef each call.
Use copy(..) instead of manually copying bytes
- This is likely to be faster, since copy has architecture-specialized implementations
Use bytes.Equal(..) instead of manually comparing bytes
- Again, this is likely to be faster, since bytes.Equal has architecture-specialized implementations

For the record, converting an array to a slice (arr[:]) does not copy the array.

Author: @ethantkoenig Some simplifications to prevent wheel re-invention: - Use `hex.EncodeString(..)` instead of manually hex encoding - This is likely to be faster, since we don't have to allocate a byte array containg `012..ef` each call. - Use `copy(..)` instead of manually copying bytes - This is likely to be faster, since `copy` has architecture-specialized implementations - Use `bytes.Equal(..)` instead of manually comparing bytes - Again, this is likely to be faster, since `bytes.Equal` has architecture-specialized implementations For the record, converting an array to a slice (`arr[:]`) does *not* copy the array.

lunny commented

2018-02-10 11:02:47 +00:00

Author: @lunny

LGTM

Author: @lunny LGTM

This repo is archived. You cannot comment on pull requests.

No reviewers

No Milestone

No Assignees

1 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/git#111