gitea/git
Archived
46
4
Fork 1
Code Issues Pull Requests Releases Wiki Activity

Fixed a bug where TreeEntries were getting cached, (thanks @filipnavara) #139

Merged
lunny merged 1 commits from Kasi-R/master into master 2019-01-16 03:17:41 +00:00
Conversation 4 Commits 1 Files Changed 1 +17 -5
lunny commented 2019-01-08 18:39:31 +00:00
Owner
Copy Link

Author: @Kasi-R

Fixes the bug described at https://github.com/go-gitea/git/pull/123#issuecomment-452340523

Author: @Kasi-R Fixes the bug described at https://github.com/go-gitea/git/pull/123#issuecomment-452340523
lunny commented 2019-01-08 18:40:48 +00:00
Author
Owner
Copy Link

Author: @codecov-io

Codecov Report

Merging #139 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #139   +/-   ##
=======================================
  Coverage   32.46%   32.46%           
=======================================
  Files          28       28           
  Lines        1814     1814           
=======================================
  Hits          589      589           
  Misses       1148     1148           
  Partials       77       77
Impacted Files Coverage Δ
tree.go 53.06% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c811eb4...241f254. Read the comment docs.

Author: @codecov-io # [Codecov](https://codecov.io/gh/go-gitea/git/pull/139?src=pr&el=h1) Report > Merging [#139](https://codecov.io/gh/go-gitea/git/pull/139?src=pr&el=desc) into [master](https://codecov.io/gh/go-gitea/git/commit/c811eb4fb0f1fbde0174c298b418c9fca25ab09e?src=pr&el=desc) will **not change** coverage. > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/go-gitea/git/pull/139/graphs/tree.svg?width=650&token=sCATTcwuUJ&height=150&src=pr)](https://codecov.io/gh/go-gitea/git/pull/139?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #139 +/- ## ======================================= Coverage 32.46% 32.46% ======================================= Files 28 28 Lines 1814 1814 ======================================= Hits 589 589 Misses 1148 1148 Partials 77 77 ``` | [Impacted Files](https://codecov.io/gh/go-gitea/git/pull/139?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [tree.go](https://codecov.io/gh/go-gitea/git/pull/139/diff?src=pr&el=tree#diff-dHJlZS5nbw==) | `53.06% <0%> (ø)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-gitea/git/pull/139?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-gitea/git/pull/139?src=pr&el=footer). Last update [c811eb4...241f254](https://codecov.io/gh/go-gitea/git/pull/139?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
lunny commented 2019-01-08 18:43:56 +00:00
Author
Owner
Copy Link

Author: @filipnavara

On second thought, the entriesRecursiveParsed and entriesParsed variables are actually never set. Either that should be fixed too, or the cache can be removed entirely (since it was never working anyway).

Sorry, should have noticed that earlier, but I was blindly following the code when updating my forked code base.

Author: @filipnavara On second thought, the `entriesRecursiveParsed` and `entriesParsed` variables are actually never set. Either that should be fixed too, or the cache can be removed entirely (since it was never working anyway). _Sorry, should have noticed that earlier, but I was blindly following the code when updating my forked code base._
lunny commented 2019-01-08 18:46:30 +00:00
Author
Owner
Copy Link

Author: @Kasi-R

I guess i can add the caching check to both functions.

Edit: Updated the caching flag. Squashed the two commits.

Author: @Kasi-R I guess i can add the caching check to both functions. Edit: Updated the caching flag. Squashed the two commits.
lunny commented 2019-01-16 03:18:11 +00:00
Author
Owner
Copy Link

Author: @lunny

Please send a upgrade PR to go-gitea/gitea

Author: @lunny Please send a upgrade PR to go-gitea/gitea
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
in progress

   
kind/bug

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
lgtm/done

   
lgtm/need 1

   
lgtm/need 2

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
refactor

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
status/blocked

   
status/needs-feedback

   
status/wip
No Label
in progress
kind/bug
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/security
kind/testing
kind/translation
kind/ui
lgtm/done
lgtm/need 1
lgtm/need 2
priority/critical
priority/low
priority/maybe
priority/medium
refactor
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
status/blocked
status/needs-feedback
status/wip
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/git#139
No description provided.
Delete Branch "Kasi-R/master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?