Fix panic on signed empty commit message (go-gitea/gitea#6292) #149

lunny · 2019-03-09T21:57:04Z

lunny commented

2019-03-09 21:57:04 +00:00

Fix panic on signed empty commit message (go-gitea/gitea#6292)

CommitTrees with empty commit messages such as signed tags will panic when trying to parse their commit message. This PR fixes this.

Author: @zeripath Fix panic on signed empty commit message (go-gitea/gitea#6292) CommitTrees with empty commit messages such as signed tags will panic when trying to parse their commit message. This PR fixes this.

lunny commented

2019-03-09 21:58:21 +00:00

Author: @codecov-io

Codecov Report

Merging #149 into master will decrease coverage by 0.05%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
- Coverage   36.48%   36.42%   -0.06%     
==========================================
  Files          28       28              
  Lines        1839     1842       +3     
==========================================
  Hits          671      671              
- Misses       1079     1080       +1     
- Partials       89       91       +2

Impacted Files	Coverage Δ
repo_commit.go	`28.36% <40%> (-0.32%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cba05a...96e9f16. Read the comment docs.

Author: @codecov-io # [Codecov](https://codecov.io/gh/go-gitea/git/pull/149?src=pr&el=h1) Report > Merging [#149](https://codecov.io/gh/go-gitea/git/pull/149?src=pr&el=desc) into [master](https://codecov.io/gh/go-gitea/git/commit/6cba05a15095efee8d444c36e5363e22939bdd84?src=pr&el=desc) will **decrease** coverage by `0.05%`. > The diff coverage is `40%`. [![Impacted file tree graph](https://codecov.io/gh/go-gitea/git/pull/149/graphs/tree.svg?width=650&token=sCATTcwuUJ&height=150&src=pr)](https://codecov.io/gh/go-gitea/git/pull/149?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #149 +/- ## ========================================== - Coverage 36.48% 36.42% -0.06% ========================================== Files 28 28 Lines 1839 1842 +3 ========================================== Hits 671 671 - Misses 1079 1080 +1 - Partials 89 91 +2 ``` | [Impacted Files](https://codecov.io/gh/go-gitea/git/pull/149?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [repo\_commit.go](https://codecov.io/gh/go-gitea/git/pull/149/diff?src=pr&el=tree#diff-cmVwb19jb21taXQuZ28=) | `28.36% <40%> (-0.32%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-gitea/git/pull/149?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-gitea/git/pull/149?src=pr&el=footer). Last update [6cba05a...96e9f16](https://codecov.io/gh/go-gitea/git/pull/149?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

This repo is archived. You cannot comment on pull requests.

No reviewers

No Milestone

No Assignees

1 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/git#149