Highlight that the PROTOCOL value has to be lowercase #38

Closed
opened 2023-07-04 07:07:41 +00:00 by MiloCubed · 5 comments

Hello, may I first confirm that the app.ini PROTOCOL config is case sensitive (must be lowercase)?

If so, I'd like to suggest for it to be highlighted in the HTTPS Setup page.

Perhaps something like:

For the PROTOCOL=https field, make sure https is lowercase. Writing PROTOCOL=HTTPS may result in a SSL_ERROR_RX_RECORD_TOO_LONG error on Firefox or ERR_SSL_PROTOCOL_ERROR on Chrome and Edge.

Background

At first I carelessly wrote PROTOCOL=HTTPS in my app.ini, and Firefox didn't allow me to connect because:

Secure Connection Failed
An error occurred during a connection to gitea.local.lan. SSL received a record that exceeded the maximum permissible length.
Error code: SSL_ERROR_RX_RECORD_TOO_LONG

I spent maybe half an hour troubleshooting my certs, ports, and other configs before backtracking to the start and realizing the capitalization difference there 😅. When I changed that config to lowercase, it worked.

Hello, may I first confirm that the app.ini PROTOCOL config is case sensitive (must be lowercase)? If so, I'd like to suggest for it to be highlighted in the [HTTPS Setup](https://docs.gitea.com/administration/https-setup#using-the-built-in-server) page. Perhaps something like: > For the `PROTOCOL=https` field, make sure `https` is lowercase. Writing `PROTOCOL=HTTPS` may result in a SSL_ERROR_RX_RECORD_TOO_LONG error on Firefox or ERR_SSL_PROTOCOL_ERROR on Chrome and Edge. ## Background At first I carelessly wrote `PROTOCOL=HTTPS` in my app.ini, and Firefox didn't allow me to connect because: > Secure Connection Failed > An error occurred during a connection to gitea.local.lan. SSL received a record that exceeded the maximum permissible length. > Error code: SSL_ERROR_RX_RECORD_TOO_LONG I spent maybe half an hour troubleshooting my certs, ports, and other configs before backtracking to the start and realizing the capitalization difference there 😅. When I changed that config to lowercase, it worked.
Owner

Could you help to submit a PR to fix that?

Could you help to submit a PR to fix that?
Author

PS. Seems like the "Config Cheat Sheet" link in this paragraph is broken:

Note that if your certificate is signed by a third party [...] To learn more about the config values, please checkout the Config Cheat Sheet.

It links to https://docs.gitea.com/config-cheat-sheet#server-server but seems like the cheat sheet page is now at https://docs.gitea.com/administration/config-cheat-sheet#server-server

PS. Seems like the "Config Cheat Sheet" link in this paragraph is broken: > Note that if your certificate is signed by a third party [...] To learn more about the config values, please checkout the [Config Cheat Sheet](https://docs.gitea.com/config-cheat-sheet#server-server). It links to https://docs.gitea.com/config-cheat-sheet#server-server but seems like the cheat sheet page is now at https://docs.gitea.com/administration/config-cheat-sheet#server-server
Author

Could you help to submit a PR to fix that?

Sure

> Could you help to submit a PR to fix that? Sure
Author

Could you help to submit a PR to fix that?

Done -- https://github.com/go-gitea/gitea/pull/25685

> Could you help to submit a PR to fix that? Done -- https://github.com/go-gitea/gitea/pull/25685
Owner
https://github.com/go-gitea/gitea/pull/25685 merged.
lunny closed this issue 2023-10-19 08:15:02 +00:00
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/gitea-docusaurus#38
No description provided.