git do partial clone #42

Closed
6543 wants to merge 1 commits from 6543-forks/gitea-docusaurus:partial-clone into main
Owner

close #31
close #30

close #31 close #30
6543 added 1 commit 2023-07-05 18:01:31 +00:00
All checks were successful
checks / build-docs (pull_request) Successful in 6m52s
59a3a22d64
git do partial clone
Author
Owner

drop clone speed from ~40s to ~12s

drop clone speed from ~40s to ~12s
Author
Owner

a sparse-checkout would only speedup the checkout ... we can do that lager

a `sparse-checkout` would only speedup the checkout ... we can do that lager
6543 requested review from techknowlogick 2023-07-05 18:07:57 +00:00

the depth 1 was removed because it was needed for the "is outdated" calculation of translated documentation.

the depth 1 was removed because it was needed for the "is outdated" calculation of translated documentation.
Author
Owner

well in this case i would argue to improve the check_outdated script ... as the main speed-improvement happens via depth

well in this case i would argue to improve the check_outdated script ... as the main speed-improvement happens via depth
Owner

the depth 1 was removed because it was needed for the "is outdated" calculation of translated documentation.

Yes, this will make the outdated version feature invalid.

> the depth 1 was removed because it was needed for the "is outdated" calculation of translated documentation. Yes, this will make the outdated version feature invalid.
silverwind reviewed 2023-07-06 15:44:02 +00:00
@ -1,3 +1,5 @@
GTI_CLONE_OPT ?= --filter=tree:0 --depth=1
Member

Typo GTI, would recommend GIT_CLONE_OPTS and I prefer := to avoid accidential overrides from shell env vars.

Typo `GTI`, would recommend `GIT_CLONE_OPTS` and I prefer `:=` to avoid accidential overrides from shell env vars.
Author
Owner

well that was intentionall to let it be overwritten on demand

well that was intentionall to let it be overwritten on demand
Member

I had issues in the past with env vars set in my shell which accidentially override such vars so I avoid overridability where possible. Probably not very likely to happen with this name, but still possible.

I had issues in the past with env vars set in my shell which accidentially override such vars so I avoid overridability where possible. Probably not very likely to happen with this name, but still possible.
Owner

This drastically improves the build time on my machine. What alternatives are there for checking outdated?

At the very least we should get something akin to this for local dev. (other than munging the Makefile each time)

This _drastically_ improves the build time on my machine. What alternatives are there for checking outdated? At the very least we should get something akin to this for local dev. (other than munging the Makefile each time)
lunny referenced this issue from a commit 2023-07-28 05:52:37 +00:00
Owner

Resolved in #52

Not a partial clone, but the underlying issue of speeding up clones is fixed while also retaining the "outdated" check.

Resolved in #52 Not a partial clone, but the underlying issue of speeding up clones is fixed while also retaining the "outdated" check.
jolheiser closed this pull request 2023-07-29 21:31:36 +00:00
All checks were successful
checks / build-docs (pull_request) Successful in 6m52s
Required
Details

Pull request closed

Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/gitea-docusaurus#42
No description provided.