New Check: XORM #3

New Issue

`if there is a engine in a function ... check if Exported Functions are used witch have a unexported version too, if so ling -> fail` -> https://github.com/go-gitea/gitea/pull/13092

zeripath commented

2020-10-23 22:20:10 +00:00

So I just realised that you're being passed an *analysis.Pass object that has the files of the package already parsed as go ast.File s meaning that you don't really need to drop down to calling go list externally - you can get it from each file.

In fact that also means that we could literally find the naughty line of code that caused the import and print it out to the user potentially using ast.Walk.

In any case implementing these checks would require that level of code.

In some ways, dealing with and preventing both of these problems by destroying models.x would likely be less work overall. So as fun as coding with the ast might be that might actually be the better option.

So I just realised that you're being passed an `*analysis.Pass` object that has the files of the package already parsed as go `ast.File` s meaning that you don't really need to drop down to calling `go list` externally - you can get it from each file. In fact that also means that we could literally find the naughty line of code that caused the import and print it out to the user potentially using `ast.Walk`. In any case implementing these checks would require that level of code. In some ways, dealing with and preventing both of these problems by destroying models.x would likely be less work overall. So as fun as coding with the ast might be that might actually be the better option.

Sign in to join this conversation.