Suggest: return test #8

New Issue

a1012112796 · 2020-08-03T16:28:11Z

a1012112796 commented

2020-08-03 16:28:11 +00:00

Maybe we need to add some checks to find problems similar to https://github.com/go-gitea/gitea/pull/12420

Which means should return after ctx.Redirect, ctx.ServerError, and so on , if it's not the end of function.
Or sometimes, these small nits will make dangerous security bugs.

Maybe we need to add some checks to find problems similar to https://github.com/go-gitea/gitea/pull/12420 Which means should return after ctx.Redirect, ctx.ServerError, and so on , if it's not the end of function. Or sometimes, these small nits will make dangerous security bugs.

👍 1

a1012112796 changed title from ~~Suggest:~~ to Suggest: return test

2020-08-03 16:29:01 +00:00

a1012112796 commented

2020-08-03 16:40:32 +00:00

@lunny When I entered the title of this issue, I accidentally pressed the enter key and the issue was submitted, which seems a little unreasonable...

1

lunny added the

enhancement

label 2020-08-04 08:19:06 +00:00

Sign in to join this conversation.