gitea/gitea-vet
41
6
Fork 10
Code Issues 5 Pull Requests 1 Actions Releases 5 Activity

If you open a session either return it or close it #16

Merged
6543 merged 10 commits from zeripath/gitea-vet:i-see-a-session-and-i-want-it-painted-black into master 2021-04-12 22:12:05 +00:00
Conversation 3 Commits 10 Files Changed 2 +194
zeripath commented 2021-04-10 15:22:22 +00:00
Owner
Copy Link

If you call sess := x.NewSession() you must call sess.Close() or return the session.

This is not quite completely perfect for example if you return the output of x.NewSession() immediately it will falsely claim that you're not closing it. However it shows the beginnings of how to do it.

Signed-off-by: Andrew Thornton art27@cantab.net

close #15

If you call `sess := x.NewSession()` you must call `sess.Close()` or return the session. This is not quite completely perfect for example if you return the output of x.NewSession() immediately it will falsely claim that you're not closing it. However it shows the beginnings of how to do it. Signed-off-by: Andrew Thornton <art27@cantab.net> close #15
zeripath added 1 commit 2021-04-10 15:22:23 +00:00
If you open a session either return it or close it 
Signed-off-by: Andrew Thornton <art27@cantab.net>
b230edbf82
lunny approved these changes 2021-04-10 15:50:37 +00:00
Dismissed
6543 approved these changes 2021-04-10 16:05:55 +00:00
Dismissed
zeripath added 1 commit 2021-04-10 16:22:24 +00:00
remove unnecessary logging statement 
Signed-off-by: Andrew Thornton <art27@cantab.net>
Some checks failed
continuous-integration/drone/pr Build is failing
Details
cdbfe42d19
zeripath added 1 commit 2021-04-10 16:32:24 +00:00
handle the final type of returned session 
Signed-off-by: Andrew Thornton <art27@cantab.net>
61d5607d85
zeripath added 1 commit 2021-04-10 17:16:34 +00:00
slight restructor 
Signed-off-by: Andrew Thornton <art27@cantab.net>
Some checks failed
continuous-integration/drone/pr Build is failing
Details
90f96d321b
zeripath added 1 commit 2021-04-10 17:44:06 +00:00
mawr simplicification 
Signed-off-by: Andrew Thornton <art27@cantab.net>
8110a1b6da
zeripath added 1 commit 2021-04-10 17:49:43 +00:00
mawr simplicification 2 
Signed-off-by: Andrew Thornton <art27@cantab.net>
aa13fe82c3
zeripath added 1 commit 2021-04-10 18:22:59 +00:00
Come on drone... 
Signed-off-by: Andrew Thornton <art27@cantab.net>
32652f51fa
zeripath added 1 commit 2021-04-10 21:28:24 +00:00
more docs 
Signed-off-by: Andrew Thornton <art27@cantab.net>
7270ceb76c
lunny commented 2021-04-11 01:36:04 +00:00
Owner
Copy Link

CI failed is related.

CI failed is related.
jolheiser commented 2021-04-12 15:09:35 +00:00
Owner
Copy Link

Having the ability to work with the AST in the stdlib is phenomenal.

Having the ability to work with the AST in the stdlib is phenomenal.
zeripath added 1 commit 2021-04-12 18:46:45 +00:00
come on drone 
Signed-off-by: Andrew Thornton <art27@cantab.net>
0a0c933b13
zeripath added 1 commit 2021-04-12 18:51:53 +00:00
more documentation 
Please drone please recognise this

Signed-off-by: Andrew Thornton <art27@cantab.net>
All checks were successful
continuous-integration/drone/pr Build is passing
Details
7e429b7ca7
zeripath commented 2021-04-12 18:52:56 +00:00
Author
Owner
Copy Link

CI has finally run again!

CI has finally run again!
6543 approved these changes 2021-04-12 22:11:43 +00:00
Dismissed
6543 merged commit 7c98703580 into master 2021-04-12 22:12:05 +00:00
wolfogre added this to the v0.2.2 milestone 2022-12-02 02:10:04 +00:00
wolfogre added the
feature
 label 2022-12-02 02:10:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
breaking

Introduce a breaking change

  
bug

Something is not working

  
build

Changes to builds

  
duplicate

This issue or pull request already exists

  
enhancement

An Imprufement

  
feature

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
skip-changelog

   
wontfix

This won't be fixed

No Label
breaking
bug
build
duplicate
enhancement
feature
help wanted
invalid
question
skip-changelog
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.2.2
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/gitea-vet#16
No description provided.
Delete Branch "zeripath/gitea-vet:i-see-a-session-and-i-want-it-painted-black"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?