ListPullRequestsOptions does not work? #161

Closed
opened 2019-04-19 04:36:00 +00:00 by lunny · 3 comments
Owner

Author: @quantonganh

7d954d7754/gitea/pull.go (L77)

How does this work?

7d954d7754/gitea/gitea.go (L109)

7d954d7754/gitea/gitea.go (L73)

7d954d7754/gitea/gitea.go (L55)

You passed body as a JSON to a GET request and expect it will be converted to a query string?

Author: @quantonganh https://github.com/go-gitea/go-sdk/blob/7d954d775498ad54b89860eb587f9692f68a1875/gitea/pull.go#L77 How does this work? https://github.com/go-gitea/go-sdk/blob/7d954d775498ad54b89860eb587f9692f68a1875/gitea/gitea.go#L109 https://github.com/go-gitea/go-sdk/blob/7d954d775498ad54b89860eb587f9692f68a1875/gitea/gitea.go#L73 https://github.com/go-gitea/go-sdk/blob/7d954d775498ad54b89860eb587f9692f68a1875/gitea/gitea.go#L55 You passed body as a JSON to a GET request and expect it will be converted to a query string?
Author
Owner

Author: @lunny

I think give a body param to a GET request is not a normal usage. But I have tested tea pulls, see https://github.com/go-gitea/tea, it works.

Author: @lunny I think give a body param to a `GET` request is not a normal usage. But I have tested `tea pulls`, see https://github.com/go-gitea/tea, it works.
Author
Owner

Author: @quantonganh

@lunny Have you tried tea pulls with a repo which has no open pull requests? https://github.com/go-gitea/tea/issues/17

Author: @quantonganh @lunny Have you tried `tea pulls` with a repo which has no open pull requests? https://github.com/go-gitea/tea/issues/17
Owner

Fixed by #219

Fixed by #219
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#161
No description provided.