SDK depends on Gitea #177

New Issue

lunny · 2019-06-04T09:11:01Z

lunny commented

2019-06-04 09:11:01 +00:00

go-sdk depends currently on code.gitea.io/gitea that implicates that all dependencies of gitea are needed to for go-sdk. We should consider fixing this since it will increase the size of binaries of tools using the sdk.

Author: @jonasfranz go-sdk depends currently on code.gitea.io/gitea that implicates that all dependencies of gitea are needed to for go-sdk. We should consider fixing this since it will increase the size of binaries of tools using the sdk.

lunny commented

2019-06-05 03:10:33 +00:00

Author: @lunny

In fact, it only depends code.gitea.io/gitea/modules/structs, but go mod will require all the packages of gitea. Maybe we should put go.mod on code.gitea.io/gitea/modules/structs to fix this problem?

Author: @lunny In fact, it only depends `code.gitea.io/gitea/modules/structs`, but `go mod` will require all the packages of gitea. Maybe we should put go.mod on `code.gitea.io/gitea/modules/structs` to fix this problem?

lunny commented

2019-06-13 08:28:37 +00:00

This cannot be resolved even if code.gitea.io/gitea/modules/structs becomes a module.

lunny commented

2019-09-14 05:04:28 +00:00

I think @jonasfranz is right. We have to fix this.

I propose to remove the dependency on code.gitea.io/gitea/modules/structs and copy all necessary structs from that packages.

And we should create branches/tags to follow gitea's version so that we can avoid a compatible problem. That means when gitea create a new branch i.ie release/v1.10. sdk should also create a branch release/v1.10 to follow gitea's change. Then you could use different branch to operate different version Gitea.

I think @jonasfranz is right. We have to fix this. I propose to remove the dependency on `code.gitea.io/gitea/modules/structs` and copy all necessary structs from that packages. And we should create branches/tags to follow gitea's version so that we can avoid a compatible problem. That means when gitea create a new branch i.ie release/v1.10. `sdk` should also create a branch release/v1.10 to follow gitea's change. Then you could use different branch to operate different version Gitea.

lunny commented

2019-09-14 05:58:15 +00:00

I sent a PR #188 to resolve this problem. Please review.

lunny commented

2019-11-05 13:19:08 +00:00

Closed by #188.

lunny closed this issue

2019-11-05 13:19:09 +00:00

Sign in to join this conversation.

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#177