Update TrackedTime #196

New Issue

noerw · 2019-12-17T18:21:30Z

noerw commented

2019-12-17 18:21:30 +00:00

Adapt TrackedTime to recent changes in https://github.com/go-gitea/gitea/pull/9200 scheduled for v1.11.
Needed for gitea/tea#54

Not sure when in the release cycle you adapt to changes.

May I ask why such types are redefined in this package, instead of referencing the original types in the gitea main code?

Adapt `TrackedTime` to recent changes in https://github.com/go-gitea/gitea/pull/9200 scheduled for v1.11. Needed for https://gitea.com/gitea/tea/pulls/54 Not sure when in the release cycle you adapt to changes. May I ask why such types are redefined in this package, instead of referencing the original types in the gitea main code?

jolheiser commented

2019-12-17 18:23:24 +00:00

May I ask why such types are redefined in this package, instead of referencing the original types in the gitea main code?

That would require anyone who wishes to use the SDK to have the entirety of Gitea as a dependency afaik.

On the opposite side of this being "why doesn't Gitea instead use the SDK as a dependency", we didn't want to make contributions more complicated by requiring a PR in two places for one feature that would change a struct.
It's a double-edged sword. 😦

> May I ask why such types are redefined in this package, instead of referencing the original types in the gitea main code? That would require anyone who wishes to use the SDK to have the entirety of Gitea as a dependency afaik. On the opposite side of this being "why doesn't Gitea instead use the SDK as a dependency", we didn't want to make contributions more complicated by requiring a PR in two places for one feature that would change a struct. It's a double-edged sword. :frowning:

noerw commented

2019-12-17 18:32:07 +00:00

Ah, makes sense. Maybe having a thin models/types package would solve this (would require changes to 2 repos still even for gitea core contributions)

Ah, makes sense. Maybe having a thin `models`/`types` package would solve this (would require changes to 2 repos still even for gitea core contributions)

noerw referenced this issue

2019-12-17 18:59:41 +00:00

update TrackedTimes structs (#196) #198

techknowlogick commented

2019-12-17 20:37:05 +00:00

Previously this repo was that second package where the types were stored, however we found it was difficult to backport changes, as well as when merging in PRs we had conflicts when some PRs merged in here, conflicted with PRs in other repo. After moving types to main repo these issues went away, but it came with some overhead that you noticed. So if we had a third repo that both of these imported from we'd still run into the same issues as before.

6543 commented

2019-12-18 00:37:13 +00:00

@techknowlogick can we add a CI task wich creat a issue when something is merged into master wich has struct changes?

with content what was toutched so we can update?

@techknowlogick can we add a CI task wich creat a issue when something is merged into master wich has struct changes? with content what was toutched so we can update?

1

lunny commented

2019-12-18 00:59:15 +00:00

@6543 sounds a good idea.

lunny added the

kind/proposal

label 2019-12-18 00:59:29 +00:00

6543 commented

2019-12-18 03:12:27 +00:00

created https://github.com/go-gitea/gitea/issues/9399 to have a record of this

since this issue (#196) is only about TrackedTime struct

@lunny