make sure usernames & reponames are url encoded #271

New Issue

6543 · 2020-02-08T10:09:39Z

6543 commented

2020-02-08 10:09:39 +00:00

"the SDK does not do any URL pathencoding for putative usernames or reponames - if say we relax the rules for reponames to allow umlauts or you want to use the SDK elsewhere you need to pathencode them" - zeripath

6543 commented

2020-02-08 10:11:22 +00:00

[x] does link, _ := url.Parse(...) encode when you use link.String()

ToDo:

add check if user/repo-name is empty
use net/url for links to encode

[x] does `link, _ := url.Parse(...)` encode when you use `link.String()` ToDo: * [ ] add check if user/repo-name is empty * [ ] use net/url for links to encode

6543 added the

kind/enhancement

label 2020-02-08 10:11:55 +00:00

techknowlogick commented

2020-02-09 01:28:51 +00:00

One of the reasons why we currently don't allow "special" characters for repo/usernames, is that the gitea stores repos on disk in an non-efficient manner, such that on disk the folders are named username/repo.git and some filesystems (really bad ones) dont allow "special" characters as folder names.

Note: I put "special" in quotes, as those characters aren't special but some computers/filesystems can't handle them due to their creators not considering non-english alphabets (quelle surprise).

One of the reasons why we currently don't allow "special" characters for repo/usernames, is that the gitea stores repos on disk in an non-efficient manner, such that on disk the folders are named username/repo.git and some filesystems (really bad ones) dont allow "special" characters as folder names. Note: I put "special" in quotes, as those characters aren't special but some computers/filesystems can't handle them due to their creators not considering non-english alphabets (quelle surprise).

👍 2

zeripath commented

2020-02-15 20:35:03 +00:00

And I have an idea for how to avoid that...

Repositories should just be stored by id.

And I have an idea for how to avoid that... Repositories should just be stored by id.

6543 commented

2020-02-15 22:33:24 +00:00

@zeripath this is a ustream problem i think (have to fix in gitea)