On Internal Server Error, show request witch caused this #296

Merged
zeripath merged 1 commits from 6543/go-sdk:on-500-show-request into master 2020-03-31 11:19:22 +00:00
Owner

close #284 (on InternalServer error the sdk should print usefrull info)

close #284 (on InternalServer error the sdk should print usefrull info)
6543 added the
kind/bug
label 2020-03-30 22:44:44 +00:00
6543 added this to the v0.12.0 milestone 2020-03-30 22:44:55 +00:00
Member

Wouldn't it be even more useful to print the actual error message from the api?

Wouldn't it be even more useful to print the actual error message from the api?
Owner

We can check the permissions, once it's site admin, we can return the actual error message. But for plain user, I think it's related with a security problem.

We can check the permissions, once it's site admin, we can return the actual error message. But for plain user, I think it's related with a security problem.
lunny approved these changes 2020-03-31 00:51:02 +00:00
Dismissed
Author
Owner

@noerw the error is returned ... if your instance is running in dev mode but in plain html witch is not realy redable in terminal - I have this issue with the changelog tool and cant realy debug it easely ... because I dont know what request cause this :/

if you run in production you wont see the issue at all so it is only a useless html error page witch is printed raw to the terminal

at the moment :(

@noerw the error is returned ... if your instance is running in dev mode but in plain html witch is not realy redable in terminal - I have this issue with the changelog tool and cant realy debug it easely ... because I dont know what request cause this :/ if you run in production you wont see the issue at all so it is only a useless html error page witch is printed raw to the terminal at the moment :(
6543 added the
need/backport
label 2020-03-31 01:08:32 +00:00
6543 added
kind/enhancement
has/backport
and removed
need/backport
labels 2020-03-31 01:34:49 +00:00
zeripath approved these changes 2020-03-31 11:19:09 +00:00
Dismissed
zeripath closed this pull request 2020-03-31 11:19:21 +00:00
6543 deleted branch on-500-show-request 2020-03-31 11:20:36 +00:00
Sign in to join this conversation.
No description provided.