gitea/go-sdk
44
46
Fork 72
Code Issues 21 Pull Requests 7 Actions Releases 19 Activity

Migration Api Changed #392

Merged
jolheiser merged 3 commits from 6543/go-sdk:migration-api-changed into master 2020-09-12 13:58:23 +00:00
Conversation 5 Commits 3 Files Changed 3 +116 -27
6543 commented 2020-08-28 07:04:38 +00:00
Owner
Copy Link
No description provided.
6543 added the
kind/enhancement
 label 2020-08-28 07:05:25 +00:00
6543 added this to the v0.13.0 milestone 2020-08-28 07:05:29 +00:00
6543 added the
status/needs-reviews
 label 2020-08-28 07:25:18 +00:00
zeripath approved these changes 2020-08-28 08:40:39 +00:00
Dismissed
jolheiser commented 2020-08-28 13:27:01 +00:00
Owner
Copy Link

We may want to either remove Gitea/Gogs, or add documentation that they are not actually fully supported services for migrations.

They can be cloned, however neither will transfer items.

We may want to either remove Gitea/Gogs, or add documentation that they are not actually fully supported services for migrations. They can be cloned, however neither will transfer items.
jolheiser requested changes 2020-08-28 13:34:05 +00:00
Dismissed
gitea/repo_migrate.go Outdated
@ -0,0 +76,4 @@
return fmt.Errorf("Description to long")
}
switch opt.Service {
case GitServiceGithub:
jolheiser commented 2020-08-28 13:29:07 +00:00
Owner
Copy Link

GitLab also has token support and so should probably prefer it.

GitLab also has token support and so should probably prefer it.
6543 commented 2020-08-30 21:30:21 +00:00
Author
Owner
Copy Link

@jolheiser this will force it too and fail with basicAuth !!!

@jolheiser this will force it too and **fail** with basicAuth !!!
6543 marked this conversation as resolved
gitea/repo_migrate.go Outdated
@ -0,0 +78,4 @@
switch opt.Service {
case GitServiceGithub:
if len(opt.AuthToken) == 0 {
return fmt.Errorf("github require token authentification")
jolheiser commented 2020-08-28 13:31:17 +00:00
Owner
Copy Link

authentication

`authentication`
6543 marked this conversation as resolved
6543 added
status/wip
 and removed
status/needs-reviews
 labels 2020-08-28 13:47:40 +00:00
6543 commented 2020-08-28 13:49:06 +00:00
Author
Owner
Copy Link

@jolheiser I'll coment out things until they are supported

and as lafriks wrote, we should have a try to switch to strig on the API

@jolheiser I'll coment out things until they are supported and as lafriks wrote, we should have a try to switch to strig on the API
6543 force-pushed migration-api-changed from 662b447403 to 884f257508 2020-09-05 00:01:39 +00:00 Compare
6543 added
status/blocked
 and removed
status/wip
 labels 2020-09-05 00:02:07 +00:00
6543 commented 2020-09-05 00:02:22 +00:00
Author
Owner
Copy Link

blocked until https://github.com/go-gitea/gitea/pull/12672 got merged

blocked until https://github.com/go-gitea/gitea/pull/12672 got merged
6543 added
status/needs-reviews
 and removed
status/blocked
 labels 2020-09-10 23:37:38 +00:00
6543 requested review from jolheiser 2020-09-10 23:37:57 +00:00
jolheiser reviewed 2020-09-11 15:55:00 +00:00
Dismissed
jolheiser left a comment
Owner
Copy Link

Not a blocker, but I don't think we should be promoting a Gogs service since we don't actually support a "full" migration.

Not a blocker, but I don't think we should be promoting a Gogs service since we don't actually support a "full" migration.
gitea/repo_migrate.go Outdated
@ -0,0 +23,4 @@
// GitServiceGitlab represents a gitlab service
GitServiceGitlab GitServiceType = "gitlab"
// GitServiceGogs represents a gogs service
GitServiceGogs GitServiceType = "gogs"
jolheiser commented 2020-09-11 15:53:24 +00:00
Owner
Copy Link

Sorry, I know that this is accepted even in the API, but imo we shouldn't be promoting a service that doesn't actually exist.
Currently this will just fall through as we don't have a Gogs factory, essentially making this a plain git migration.

Sorry, I know that this is accepted even in the API, but imo we shouldn't be promoting a service that doesn't actually exist. Currently this will just fall through as we don't have a Gogs factory, essentially making this a plain git migration.
6543 commented 2020-09-11 22:51:04 +00:00
Author
Owner
Copy Link

I'll comment it out until we have one

I'll comment it out until we have one
6543 marked this conversation as resolved
6543 commented 2020-09-12 00:43:24 +00:00
Author
Owner
Copy Link

@jolheiser comment out unsupported things

@jolheiser comment out unsupported things
jolheiser commented 2020-09-12 03:24:46 +00:00
Owner
Copy Link

@jolheiser comment out unsupported things

I still see it in the diff, did you commit the change?

> @jolheiser comment out unsupported things I still see it in the diff, did you commit the change?
6543 force-pushed migration-api-changed from 34b6b0bc71 to f4327b850a 2020-09-12 04:25:20 +00:00 Compare
6543 added 1 commit 2020-09-12 04:27:17 +00:00
comment out not-supported-git-services
All checks were successful
continuous-integration/drone/pr Build is passing
Details
7dcebd3d72
6543 added 1 commit 2020-09-12 04:30:07 +00:00
better code comments
All checks were successful
continuous-integration/drone/pr Build is passing
Details
e6dc022bcf
jolheiser approved these changes 2020-09-12 13:57:46 +00:00
Dismissed
jolheiser merged commit 99768b87a7 into master 2020-09-12 13:58:14 +00:00
6543 deleted branch migration-api-changed 2020-09-12 14:18:09 +00:00
6543 removed the
status/needs-reviews
 label 2020-09-19 18:52:59 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
has/backport

   
has/pull

   
in progress

   
invalid

   
kind/breaking

   
kind/bug

   
kind/build

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/refactor

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
need/backport

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea
No Label
has/backport
has/pull
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
Milestone
Clear milestone
No items
No Milestone
v0.13.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#392
No description provided.
Delete Branch "6543/go-sdk:migration-api-changed"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?