gitea/go-sdk
44
46
Fork 72
Code Issues 21 Pull Requests 7 Actions Releases 19 Activity

Milestone Functions accept name to identify #418

Merged
6543 merged 5 commits from 6543/go-sdk:GetMilestones_add-name-to-id-resove-function into master 2020-09-15 16:29:26 +00:00
Conversation 1 Commits 5 Files Changed 2 +84 -2
6543 commented 2020-09-14 17:44:44 +00:00
Owner
Copy Link

close #383

followup of #388
source https://github.com/go-gitea/gitea/pull/12649

close #383 followup of #388 source https://github.com/go-gitea/gitea/pull/12649
6543 added this to the v0.13.0 milestone 2020-09-14 17:44:44 +00:00
6543 added the
kind/feature
status/needs-reviews
 labels 2020-09-14 17:44:44 +00:00
6543 added 2 commits 2020-09-14 17:44:51 +00:00
add Tests
All checks were successful
continuous-integration/drone/pr Build is passing
Details
87f5e6737b
zeripath reviewed 2020-09-14 19:19:47 +00:00
Dismissed
gitea/issue_milestone.go Outdated
@ -63,2 +72,3 @@
milestone := new(Milestone)
resp, err := c.getParsedResponse("GET", fmt.Sprintf("/repos/%s/%s/milestones/%d", owner, repo, id), nil, nil, milestone)
resp, err := c.getParsedResponse("GET", fmt.Sprintf("/repos/%s/%s/milestones/%s", owner, repo, id), nil, nil, milestone)
zeripath commented 2020-09-14 19:19:47 +00:00
Owner
Copy Link

The id needs a PathEscape

The id needs a PathEscape
zeripath reviewed 2020-09-14 19:20:39 +00:00
Dismissed
gitea/issue_milestone.go Outdated
@ -132,3 +155,3 @@
}
milestone := new(Milestone)
resp, err := c.getParsedResponse("PATCH", fmt.Sprintf("/repos/%s/%s/milestones/%d", owner, repo, id), jsonHeader, bytes.NewReader(body), milestone)
resp, err := c.getParsedResponse("PATCH", fmt.Sprintf("/repos/%s/%s/milestones/%s", owner, repo, id), jsonHeader, bytes.NewReader(body), milestone)
zeripath commented 2020-09-14 19:20:39 +00:00
Owner
Copy Link

simy. here

simy. here
6543 added 1 commit 2020-09-15 03:48:59 +00:00
url.PathEscape()
All checks were successful
continuous-integration/drone/pr Build is passing
Details
21e52dcea5
6543 commented 2020-09-15 03:52:16 +00:00
Author
Owner
Copy Link

@zeripath done

@zeripath done
mrsdizzie approved these changes 2020-09-15 14:02:16 +00:00
Dismissed
jolheiser reviewed 2020-09-15 14:15:25 +00:00
Dismissed
jolheiser left a comment
Owner
Copy Link

One general nit, and then one personal nit.

I personally really dislike interface options. In my opinion if we are allowing multiple ways to get something, it should have a func for each.

Even if one of them converts an int to a string and then simply delegates back to the other, it makes library usage much cleaner imo

One general nit, and then one personal nit. I personally _really_ dislike `interface` options. In my opinion if we are allowing multiple ways to get something, it should have a func for each. Even if one of them converts an `int` to a `string` and then simply delegates back to the other, it makes library usage much cleaner imo
gitea/issue_milestone.go
@ -143,0 +178,4 @@
// milestoneValueToString return string of int/int6/string and if it was converted
func milestoneValueToString(value interface{}) (string, bool, error) {
ii, ok := value.(int64)
jolheiser commented 2020-09-15 14:10:37 +00:00
Owner
Copy Link

This can all be a switch statement switch v := value.(type) {}

This can all be a switch statement `switch v := value.(type) {}`
6543 marked this conversation as resolved
6543 added 1 commit 2020-09-15 15:11:38 +00:00
do not use interface for sdk ...
All checks were successful
continuous-integration/drone/pr Build is passing
Details
534474762b
jolheiser approved these changes 2020-09-15 15:55:59 +00:00
Dismissed
jolheiser left a comment
Owner
Copy Link

I think is probably a more self-documented solution.

I think is probably a more self-documented solution.
6543 removed the
status/needs-reviews
 label 2020-09-15 16:21:07 +00:00
6543 added 1 commit 2020-09-15 16:22:20 +00:00
Merge branch 'master' into GetMilestones_add-name-to-id-resove-function
All checks were successful
continuous-integration/drone/pr Build is passing
Details
1d266eee71
6543 merged commit 83da05b95f into master 2020-09-15 16:29:26 +00:00
6543 deleted branch GetMilestones_add-name-to-id-resove-func 2020-09-15 16:29:34 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
has/backport

   
has/pull

   
in progress

   
invalid

   
kind/breaking

   
kind/bug

   
kind/build

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/refactor

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
need/backport

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea
No Label
has/backport
has/pull
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
Milestone
Clear milestone
No items
No Milestone
v0.13.0
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#418
No description provided.
Delete Branch "6543/go-sdk:GetMilestones_add-name-to-id-resove-function"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?