gitea/go-sdk
44
46
Fork 72
Code Issues 21 Pull Requests 7 Actions Releases 19 Activity

[merged] getParsedResponse return resp if getResponse return error (#428) #429

Closed
6543 wants to merge 1 commits from 6543:backport_fix-not-return-responce into release/v0.13
pull from: 6543:backport_fix-not-return-responce
merge into: gitea:release/v0.13
Conversation 3 Commits 1 Files Changed 1 +1 -1
6543 commented 2020-09-29 14:24:34 +00:00
Owner
Copy Link

Backport #428

Backport #428
6543 added the
kind/bug
priority/critical
 labels 2020-09-29 14:24:34 +00:00
6543 added 1 commit 2020-09-29 14:24:36 +00:00
getParsedResponse return resp if getResponse return error (#428) 
getParsedResponse return resp if getResponse return error

Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: #428
Reviewed-by: techknowlogick <techknowlogick@gitea.io>
Reviewed-by: John Olheiser <john.olheiser@gmail.com>
All checks were successful
continuous-integration/drone/pr Build is passing
Details
0ca531ce53
6543 added this to the v0.13.1 milestone 2020-09-29 14:24:42 +00:00
jolheiser approved these changes 2020-09-29 14:25:51 +00:00
Dismissed
techknowlogick approved these changes 2020-09-29 14:26:31 +00:00
Dismissed
lafriks commented 2020-09-29 14:34:20 +00:00
Member
Copy Link

@6543 please resolve conflict

@6543 please resolve conflict
6543 commented 2020-09-29 14:36:45 +00:00
Author
Owner
Copy Link

@lafriks see Discord, this is already merged

-> It's a BUG (pull stayed open avter merge!!)

@lafriks see Discord, this is already merged -> It's a BUG (pull stayed open avter merge!!)
👍 1 😆 1
6543 closed this pull request 2020-09-29 14:36:45 +00:00
6543 deleted branch backport_fix-not-return-responce 2020-09-29 14:36:52 +00:00
6543 changed title from getParsedResponse return resp if getResponse return error (#428) to [merged] getParsedResponse return resp if getResponse return error (#428) 2020-09-29 14:37:02 +00:00
6543 commented 2020-09-29 15:32:53 +00:00
Author
Owner
Copy Link

merged in with a9d6bd30e8

merged in with a9d6bd30e8a7dbeda976cb83bb6c83c4493def31
All checks were successful
continuous-integration/drone/pr Build is passing
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
has/backport

   
has/pull

   
in progress

   
invalid

   
kind/breaking

   
kind/bug

   
kind/build

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/refactor

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
need/backport

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea
No Label
has/backport
has/pull
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
Milestone
Clear milestone
No items
No Milestone
v0.13.1
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#429
No description provided.
Delete Branch "6543:backport_fix-not-return-responce"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?