bug: getting contents of non existing path produces misleading error #459

New Issue

mavogel · 2020-11-20T16:03:14Z

mavogel commented

2020-11-20 16:03:14 +00:00

Current behaviour

When calling

func (c *Client) GetContents(owner, repo, ref, filepath string) (*ContentsResponse, *Response, error) {

on a non-existing filepath the following error is produced
json: cannot unmarshal array into Go value of type gitea.ContentsResponse

Desired behaviour

The error message should be more describing, like file path '/path/to/' does not exist

References

https://github.com/goreleaser/goreleaser/pull/1547#issuecomment-730031118

### Current behaviour When calling ```go func (c *Client) GetContents(owner, repo, ref, filepath string) (*ContentsResponse, *Response, error) { ``` on a non-existing filepath the following error is produced `json: cannot unmarshal array into Go value of type gitea.ContentsResponse` ### Desired behaviour The error message should be more describing, like `file path '/path/to/' does not exist` ### References - https://github.com/goreleaser/goreleaser/pull/1547#issuecomment-730031118

6543 added this to the v0.14.0 milestone 2020-11-20 18:32:07 +00:00

6543 added the

kind/bug

label 2020-11-20 18:32:17 +00:00

6543 commented

2021-02-13 05:48:33 +00:00

related to #485 ... adding tests should clarify it ...

6543 self-assigned this 2021-02-13 05:48:40 +00:00

6543 referenced a pull request that will close this issue

2021-02-16 15:28:01 +00:00

Handle Contents Edge-Case #492

6543 added the