GET /repos/{owner}/{repo}/times/{user} is deprecated #465

New Issue

noerw · 2020-12-12T19:05:30Z

noerw commented

2020-12-12 19:05:30 +00:00

see https://github.com/go-gitea/gitea/pull/9200

Several options:

remove GetUserTrackedTimes() (the name is bad anyway?)
maintain backwardcompatibility: make GetUserTrackedTimes() use the new API internally (i.e. GetRepoTrackedTimes():
```
GET /repos/{owner}/{repo}/times?user={user}
```

I think ListTrackedTimeOptions need an update too

see https://github.com/go-gitea/gitea/pull/9200 Several options: 1. remove `GetUserTrackedTimes()` (the name is bad anyway?) 2. maintain backwardcompatibility: make `GetUserTrackedTimes()` use the new API internally (i.e. `GetRepoTrackedTimes()`: ``` GET /repos/{owner}/{repo}/times?user={user} ``` I think ListTrackedTimeOptions need an update too

6543 added this to the v0.14.0 milestone 2020-12-12 20:46:50 +00:00

6543 added the

kind/enhancement

kind/breaking

labels 2020-12-12 20:50:51 +00:00

6543 commented

2020-12-12 20:50:54 +00:00

GetRepoTrackedTimes() need to be extended to accept an option struct (ListTrackedTimeOptions)

this is kind/breaking and so we can remove GetUserTrackedTimes() at that point

-> just make a note how to migrate ... (example: https://gitea.com/gitea/go-sdk/src/branch/master/docs/migrate-v0.12-to-v0.13.md)

`GetRepoTrackedTimes()` need to be extended to accept an option struct (**ListTrackedTimeOptions**) this is **kind/breaking** and so we can remove `GetUserTrackedTimes()` at that point -> just make a note how to migrate ... (example: https://gitea.com/gitea/go-sdk/src/branch/master/docs/migrate-v0.12-to-v0.13.md)

6543 referenced a pull request that will close this issue

2020-12-15 20:05:06 +00:00

Remove & Rename TrackedTimes list functions #467

6543 closed this issue

2020-12-17 10:03:48 +00:00

Sign in to join this conversation.

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#465