Remove & Rename TrackedTimes list functions #467

Merged
6543 merged 8 commits from 6543/go-sdk:rm_GetUserTrackedTimes-and-more into master 2020-12-17 10:03:48 +00:00
Owner

close #465

close #465
6543 reviewed 2020-12-15 20:07:14 +00:00
Dismissed
@ -0,0 +10,4 @@
<!-- tocstop -->
## Remove Functions for deprecated endpoints
Author
Owner

Removed ... of ...

?

Removed ... of ... ?
6543 marked this conversation as resolved
6543 added the
kind/breaking
kind/enhancement
labels 2020-12-15 20:07:53 +00:00
6543 added this to the v0.14.0 milestone 2020-12-15 20:13:07 +00:00
noerw reviewed 2020-12-15 21:36:14 +00:00
Dismissed
@ -33,0 +29,4 @@
// GetRepoTrackedTimesOptions set optional filters
type GetRepoTrackedTimesOptions struct {
User string
}
Member

This needs ListOptions as well, and ideally also since and before (accepting RFC 3339 dates).

Same for ListTrackedTimesOptions (they are equal I think, no need for a new type?)

This needs `ListOptions` as well, and ideally also `since` and `before` (accepting RFC 3339 dates). Same for `ListTrackedTimesOptions` (they are equal I think, no need for a new type?)
6543 marked this conversation as resolved
noerw changed title from Remove Getusertrackedtimes() and add options to GetRepoTrackedTimes() to Remove GetUserTrackedTimes() and add options to GetRepoTrackedTimes() 2020-12-16 17:14:12 +00:00
6543 force-pushed rm_GetUserTrackedTimes-and-more from b217cc59a9 to 6d9f68915a 2020-12-16 19:38:40 +00:00 Compare
6543 force-pushed rm_GetUserTrackedTimes-and-more from 2754d5ded9 to b001650be7 2020-12-16 19:43:20 +00:00 Compare
6543 changed title from Remove GetUserTrackedTimes() and add options to GetRepoTrackedTimes() to Remove & Rename TrackedTimes list functions 2020-12-16 19:43:52 +00:00
6543 added 1 commit 2020-12-16 19:44:45 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
a637682232
update pull title
Author
Owner

@noerw did a big refactor + add filters

@noerw did a big refactor + add filters
6543 reviewed 2020-12-16 19:46:45 +00:00
Dismissed
@ -33,0 +31,4 @@
ListOptions
Since time.Time
Before time.Time
// User filter is only used by ListRepoTrackedTimes !!!
Author
Owner

we shold add this filter for issues too -> Upstream TODO

we shold add this filter for issues too -> Upstream TODO
Author
Owner
created upstream issue: https://github.com/go-gitea/gitea/issues/14024
noerw reviewed 2020-12-16 19:56:15 +00:00
Dismissed
Member

you're now passing jsonHeader unlike before, is this intended?

you're now passing `jsonHeader` unlike before, is this intended?
6543 marked this conversation as resolved
6543 added 1 commit 2020-12-16 20:14:03 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
91bf0c7134
add jsonHeader on all tt func
Author
Owner

you're now passing jsonHeader unlike before, is this intended?

most gitea api endpoints do not care if this header is set or not, but it's a good habit.

a client should indicate what "language" he speaks

> you're now passing `jsonHeader` unlike before, is this intended? **most** gitea api endpoints do not care if this header is set or not, but it's a good habit. a client should indicate what "language" he speaks
noerw approved these changes 2020-12-16 20:23:38 +00:00
Dismissed
6543 added the
status/needs-reviews
label 2020-12-16 20:29:05 +00:00
lunny approved these changes 2020-12-17 04:49:25 +00:00
Dismissed
lunny added 1 commit 2020-12-17 04:49:30 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
64023d4f80
Merge branch 'master' into rm_GetUserTrackedTimes-and-more
6543 merged commit e34d140607 into master 2020-12-17 10:03:48 +00:00
6543 deleted branch rm_GetUserTrackedTimes-and-more 2020-12-17 10:04:03 +00:00
6543 removed the
status/needs-reviews
label 2020-12-17 10:04:20 +00:00
Sign in to join this conversation.
No description provided.