gitea/go-sdk
44
46
Fork 72
Code Issues 21 Pull Requests 7 Actions Releases 19 Activity

Fix GetCombinedStatus() #470

Merged
lunny merged 7 commits from :fix-468 into master 2020-12-17 04:46:52 +00:00
Conversation 6 Commits 7 Files Changed 2 +90 -5
noerw commented 2020-12-16 20:44:22 +00:00
Member
Copy Link

fixes #468

fixes #468
noerw added 2 commits 2020-12-16 20:44:23 +00:00
document some PullReview fields
All checks were successful
continuous-integration/drone/pr Build is passing
Details
edb96f2f29
code review
All checks were successful
continuous-integration/drone/pr Build is passing
Details
b77f66a31f
noerw added the
kind/bug
 label 2020-12-16 20:44:50 +00:00
noerw force-pushed fix-468 from ff420d35f8 to ef5beaf553 2020-12-16 20:46:42 +00:00 Compare
6543 commented 2020-12-16 20:59:11 +00:00
Owner
Copy Link

there exist

I think we have to fix ListStatuses too!!

there exist * https://gitea.com/api/swagger#/repository/repoGetCombinedStatusByRef * https://gitea.com/api/swagger#/repository/repoListStatuses I think we have to fix **ListStatuses** too!!
6543 added the
need/backport
 label 2020-12-16 21:00:47 +00:00
6543 added this to the v0.14.0 milestone 2020-12-16 21:00:53 +00:00
6543 self-assigned this 2020-12-16 21:14:37 +00:00
6543 added 2 commits 2020-12-16 22:43:24 +00:00
rename sha to ref and use jsonHeader on GetCombinedStatus
All checks were successful
continuous-integration/drone/pr Build is passing
Details
e3155ce55c
6543 changed title from fix broken GetCombinedStatus() to Fix GetCombinedStatus() and ListStatuses() 2020-12-16 22:44:41 +00:00
6543 commented 2020-12-16 22:45:38 +00:00
Owner
Copy Link
  • TODO: tests
* TODO: tests
6543 added 1 commit 2020-12-16 23:47:22 +00:00
Add Tests
All checks were successful
continuous-integration/drone/pr Build is passing
Details
64e7ed12fd
6543 added 1 commit 2020-12-17 00:30:49 +00:00
enable tests for GetCombinedStatus()
Some checks failed
continuous-integration/drone/pr Build is failing
Details
da955d648e
6543 added 1 commit 2020-12-17 01:02:19 +00:00
next fix
Some checks failed
continuous-integration/drone/pr Build is failing
Details
c8b1e7dc03
6543 added 1 commit 2020-12-17 01:11:09 +00:00
final fix
All checks were successful
continuous-integration/drone/pr Build is passing
Details
bfee1fee14
6543 changed title from Fix GetCombinedStatus() and ListStatuses() to Fix GetCombinedStatus() 2020-12-17 01:13:21 +00:00
6543 commented 2020-12-17 01:14:09 +00:00
Owner
Copy Link

the big issue here was gitea's api documentation!

https://github.com/go-gitea/gitea/pull/14026 will fix this & more

the big issue here was gitea's api documentation! https://github.com/go-gitea/gitea/pull/14026 will fix this & more
6543 approved these changes 2020-12-17 01:14:32 +00:00
Dismissed
6543 commented 2020-12-17 01:15:01 +00:00
Owner
Copy Link

@noerw since I did a lot on this pull - I thik your lgtm would be good too

@noerw since I did a lot on this pull - I thik your lgtm would be good too
6543 commented 2020-12-17 01:18:50 +00:00
Owner
Copy Link

coverage: 51.1% -> 52.0% ?

`coverage: 51.1% -> 52.0%` ?
lunny approved these changes 2020-12-17 04:46:40 +00:00
Dismissed
lunny merged commit 7ddbf1a015 into master 2020-12-17 04:46:52 +00:00
6543 referenced this issue from a commit 2020-12-17 10:40:56 +00:00
Fix GetCombinedStatus() (#470)
6543 commented 2020-12-17 10:53:42 +00:00
Owner
Copy Link

Backport -> #472

Backport -> #472
6543 added
has/backport
 and removed
need/backport
 labels 2020-12-17 10:53:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
has/backport

   
has/pull

   
in progress

   
invalid

   
kind/breaking

   
kind/bug

   
kind/build

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/refactor

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
need/backport

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea
No Label
has/backport
has/pull
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
Milestone
Clear milestone
No items
No Milestone
v0.14.0
Assignees
Clear assignees
No Assignees
6543
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#470
No description provided.
Delete Branch ":fix-468"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?