Fix GetCombinedStatus() (#470) #472

6543 · 2020-12-17T10:51:09Z

6543 commented

2020-12-17 10:51:09 +00:00

Backport #470

6543 added this to the v0.13.3 milestone 2020-12-17 10:51:09 +00:00

6543 added the

kind/bug

label 2020-12-17 10:51:10 +00:00

6543 added 1 commit 2020-12-17 10:51:46 +00:00

Fix GetCombinedStatus() (#470 )

fix broken GetCombinedStatus

weirdly enough, gitea API responds to .../status properly, if ref has a status.
but if there is no status, an empty response is returned.
../statuses handles both correctly.. 🙃

fix ListStatuses

rename sha to ref and use jsonHeader on GetCombinedStatus

Add Tests

enable tests for GetCombinedStatus()

next fix

final fix

Co-authored-by: Norwin Roosen <git@nroo.de>
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: #470
Reviewed-by: 6543 <6543@obermui.de>
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-Authored-By: Norwin <noerw@noreply.gitea.io>
Co-Committed-By: Norwin <noerw@noreply.gitea.io>

continuous-integration/drone/pr Build is passing

Details

65de8747f7

6543 referenced this pull request

2020-12-17 10:53:43 +00:00

Fix GetCombinedStatus() #470

noerw approved these changes 2020-12-17 13:31:43 +00:00

Dismissed

lunny approved these changes 2020-12-17 13:49:48 +00:00

Dismissed

lunny merged commit c8e1b4c94f into release/v0.13

2020-12-17 13:49:52 +00:00