introduce Client.GetArchiveReader #476

petergardfjall · 2021-01-15T13:46:54Z

petergardfjall commented

2021-01-15 13:46:54 +00:00

This PR fix #475

It complements the Client.GetArchive call, which returns a byte slice and hence is unsuitable for use with large repositories, with a Client.GetArchiveReader method that returns a io.ReadCloser that streams the retrieved archvie and, therefore, induces a much smaller memory footprint on the calling client.

This PR fix #475 It complements the `Client.GetArchive` call, which returns a byte slice and hence is unsuitable for use with large repositories, with a `Client.GetArchiveReader` method that returns a `io.ReadCloser` that streams the retrieved archvie and, therefore, induces a much smaller memory footprint on the calling client.

👍 1

petergardfjall force-pushed get-archive-with-readcloser from 244a7cda6c to c7fe43a3c5

2021-01-15 13:56:43 +00:00

Compare

6543 reviewed 2021-01-15 14:41:11 +00:00

Dismissed

gitea/repo.go Outdated

						
				@ -423,0 +426,4 @@

				// such as a branch name (`master`), a commit hash (`70b7c74b33`), a tag

				// (`v1.2.1`). The archive is returned as a byte stream in a ReadCloser. It is

				// the responsibility of the client to close the reader.

				func (c *Client) GetArchiveReader(owner, repo, ref string, ext ArchiveType) (io.ReadCloser, error) {