GetRepoRef() + GetRepoRefs() need changes #497

New Issue

noerw · 2021-03-07T14:41:04Z

noerw commented

2021-03-07 14:41:04 +00:00

Looking at the API capabilities, and what the SDK makes of it, it looks like these functions should behave differently:

GetRepoRef() doesnt differ from GetRepoRefs() other than trying to cast the response to a single Reference.
This is doomed to fail, as the API always seems to return an array, so this function currently is unusable anyway.
I'd argue, that GetRepoRefs() shouldn't take a ref param, and list all refs of the repo, for which there currently is no function at all.

Looking at the API capabilities, and what the SDK makes of it, it looks like these functions should behave differently: - `GetRepoRef()` doesnt differ from `GetRepoRefs()` other than trying to cast the response to a single `Reference`. This is doomed to fail, as the API always seems to return an array, so this function currently is unusable anyway. - I'd argue, that `GetRepoRefs()` shouldn't take a `ref` param, and list all refs of the repo, for which there currently is no function at all.

noerw added the

kind/breaking

kind/bug

labels 2021-03-07 14:41:36 +00:00

Sign in to join this conversation.

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#497