gitea/go-sdk

Add workaround to get head branch sha of pulls with deleted head branch #498

Merged

zeripath merged 6 commits from 6543/go-sdk:fix-empty-pull-head-sha into master

2021-03-08 21:15:43 +00:00

6543 commented

2021-03-08 20:29:37 +00:00

Owner

as title

as title

6543 added this to the v0.14.0 milestone 2021-03-08 20:29:37 +00:00

6543 added the

kind/enhancement

label 2021-03-08 20:29:37 +00:00

6543 added 3 commits 2021-03-08 20:29:38 +00:00

introduce fixPullHeadSha as workaround for old gitea instances c46df13c8b

make it more resilent ad0c06d612

format code

continuous-integration/drone/pr Build is failing

Details

9d179a1bea

noerw reviewed 2021-03-08 20:35:28 +00:00

Dismissed

gitea/pull.go

						
				@ -112,6 +119,11 @@ func (c *Client) ListRepoPullRequests(owner, repo string, opt ListPullRequestsOp

				func (c *Client) GetPullRequest(owner, repo string, index int64) (*PullRequest, *Response, error) {

					pr := new(PullRequest)

					resp, err := c.getParsedResponse("GET", fmt.Sprintf("/repos/%s/%s/pulls/%d", owner, repo, index), nil, nil, pr)

					if c.checkServerVersionGreaterThanOrEqual(version1_14_0) != nil {

noerw commented

2021-03-08 20:35:28 +00:00

Member

Move the version check into fixPullHeadSha, so it's selfdocumenting?

Move the version check into fixPullHeadSha, so it's selfdocumenting?

noerw commented

2021-03-08 20:38:13 +00:00

Member

Scratch that, I see why you did that now.
Maybe add a comment to fixPullHeadSha instead about the affected gitea versions?

Scratch that, I see why you did that now. Maybe add a comment to `fixPullHeadSha` instead about the affected gitea versions?

6543 commented

2021-03-08 20:46:00 +00:00

Author

Owner

@noerw done

6543 marked this conversation as resolved

6543 added 1 commit 2021-03-08 20:37:19 +00:00

relax test data

continuous-integration/drone/pr Build is failing

Details

ae05111399

6543 added 1 commit 2021-03-08 20:43:17 +00:00

relax test data 725d288f27

6543 added 1 commit 2021-03-08 20:45:42 +00:00

add "This is fixed for gitea >= 1.14.0"

continuous-integration/drone/pr Build is passing

Details

0cedeb440e

noerw approved these changes 2021-03-08 20:46:14 +00:00

Dismissed

zeripath approved these changes 2021-03-08 21:15:29 +00:00

Dismissed

zeripath merged commit e0cf20a456 into master

2021-03-08 21:15:42 +00:00

zeripath referenced this issue from a commit

2021-03-08 21:15:43 +00:00

Add workaround to get head branch sha of pulls with deleted head branch (#498)

6543 deleted branch fix-empty-pull-head-sha

2021-03-08 21:18:26 +00:00

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#498

No description provided.