Add GetRepoByID #511

Merged
6543 merged 1 commits from J0Nes90/go-sdk:J0Nes90/get_repo_by_id into master 2021-04-03 16:35:19 +00:00
Contributor

I've added a function go get a repository by a given ID.

I've added a function go get a repository by a given ID.
Owner

@J0Nes90 reason to still be WIP?

@J0Nes90 reason to still be WIP?
6543 added the
kind/feature
label 2021-04-03 12:04:20 +00:00
6543 added this to the v0.15.0 milestone 2021-04-03 12:04:30 +00:00
Author
Contributor

I thought it makes sense to mark it WIP as this is my first PR to this repository. Other than that there is no particular reason

I thought it makes sense to mark it WIP as this is my first PR to this repository. Other than that there is no particular reason
J0Nes90 changed title from WIP: add GetRepoByID to add GetRepoByID 2021-04-03 12:21:55 +00:00
6543 changed title from add GetRepoByID to Add GetRepoByID 2021-04-03 12:35:58 +00:00
6543 approved these changes 2021-04-03 12:41:42 +00:00
Dismissed
@ -160,0 +161,4 @@
log.Println("== TestGetRepoByID ==")
c := newTestClient()
testrepo, _ := createTestRepo(t, "TestGetRepoByID", c)
Owner
-	
+
```diff - + ```
6543 marked this conversation as resolved
@ -160,0 +164,4 @@
repo, _, err := c.GetRepoByID(testrepo.ID)
assert.NoError(t, err)
assert.NotNil(t, repo)
Owner

can you add assert.EqualValues(t, testrepo.ID, repo.ID) - just to make sure it do what is expected

@J0Nes90

can you add `assert.EqualValues(t, testrepo.ID, repo.ID)` - just to make sure it do what is expected @J0Nes90
6543 marked this conversation as resolved
Owner

@J0Nes90 just the two nits ☝️ (first one can be done with make fmt, i guess you just forgot it before commiting)

@J0Nes90 just the two nits ☝️ (first one can be done with `make fmt`, i guess you just forgot it before commiting)
J0Nes90 force-pushed J0Nes90/get_repo_by_id from a59f823ec5 to a711ae563f 2021-04-03 13:06:40 +00:00 Compare
Author
Contributor

fixed & force pushed

fixed & force pushed
6543 approved these changes 2021-04-03 16:11:57 +00:00
Dismissed
lunny approved these changes 2021-04-03 16:24:41 +00:00
Dismissed
6543 merged commit 4e4d6dd731 into master 2021-04-03 16:35:19 +00:00
6543 referenced this issue from a commit 2021-04-03 16:35:19 +00:00
Sign in to join this conversation.
No description provided.