Add GetRepoByID #511
No reviewers
Labels
No Label
has/backport
has/pull
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: gitea/go-sdk#511
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "J0Nes90/go-sdk:J0Nes90/get_repo_by_id"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I've added a function go get a repository by a given ID.
@J0Nes90 reason to still be WIP?
I thought it makes sense to mark it WIP as this is my first PR to this repository. Other than that there is no particular reason
WIP: add GetRepoByIDto add GetRepoByIDadd GetRepoByIDto Add GetRepoByID@ -160,0 +161,4 @@
log.Println("== TestGetRepoByID ==")
c := newTestClient()
testrepo, _ := createTestRepo(t, "TestGetRepoByID", c)
@ -160,0 +164,4 @@
repo, _, err := c.GetRepoByID(testrepo.ID)
assert.NoError(t, err)
assert.NotNil(t, repo)
can you add
assert.EqualValues(t, testrepo.ID, repo.ID)
- just to make sure it do what is expected@J0Nes90
@J0Nes90 just the two nits ☝️ (first one can be done with
make fmt
, i guess you just forgot it before commiting)a59f823ec5
toa711ae563f
fixed & force pushed