read on closed response body error #551

New Issue

kamandroid · 2021-10-29T19:14:19Z

kamandroid commented

2021-10-29 19:14:19 +00:00

I want to extract the body of the gitea.Response , however it appears closed
"read on closed response body error"

For example:

data, gitResp, err := client.MigrateRepo(opts)
Receive an 409 Conflict but was unable to get the message of why it failed
If i use the REST endpoints I get a response

{
    "message": "The repository with the same name already exists.",
    "url": "http://gitea-http:3000/api/swagger"
}

Figured i could read the response body i would get that info

Any insight on? Thanks

I want to extract the body of the gitea.Response , however it appears closed "read on closed response body error" For example: 1. `data, gitResp, err := client.MigrateRepo(opts)` 2. Receive an 409 Conflict but was unable to get the message of why it failed 3. If i use the REST endpoints I get a response ``` { "message": "The repository with the same name already exists.", "url": "http://gitea-http:3000/api/swagger" } ``` 4. Figured i could read the response body i would get that info Any insight on? Thanks

❤️ 1

kamandroid commented

2021-10-29 19:44:11 +00:00

I changed the code on my local and able to get the error cause ... rather than the "conflict"

On the client.go file applied a small change on func getResponse

func (c *Client) getResponse(method, path string, header http.Header, body io.Reader) ([]byte, *Response, error) {
	resp, err := c.doRequest(method, path, header, body)
	if err != nil {
		return nil, nil, err
	}
	defer resp.Body.Close()

	// check for errors
	data, err := statusCodeToErr(resp)
	if err != nil {
		return data, resp, errors.New(string(data))
	}

As you can see on the statusCodeToErr , if an err as occurred then the data contains the details of that error

I changed the code on my local and able to get the error cause ... rather than the "conflict" 1. On the client.go file applied a small change on func getResponse ``` func (c *Client) getResponse(method, path string, header http.Header, body io.Reader) ([]byte, *Response, error) { resp, err := c.doRequest(method, path, header, body) if err != nil { return nil, nil, err } defer resp.Body.Close() // check for errors data, err := statusCodeToErr(resp) if err != nil { return data, resp, errors.New(string(data)) } ``` 2. As you can see on the statusCodeToErr , if an err as occurred then the data contains the details of that error

lunny commented

2021-10-30 04:13:13 +00:00

The resp.body has been consumed in internal. Should we expose that?

The `resp.body` has been consumed in internal. Should we expose that?

lunny added the

kind/proposal

label 2021-10-30 04:13:23 +00:00

kamandroid commented

2021-10-30 16:26:24 +00:00

two choices (imho)

if you provide a http.Response then the caller assumes they also have the resp.body. so it should be exposed
the other alternative not provide the http.Response ( sdk has abstracted that away ). so now the caller is only provided the data and error

for example:

data, err := client.MigrateRepo(opts)

two choices (imho) 1. if you provide a http.Response then the caller assumes they also have the resp.body. so it should be exposed 2. the other alternative not provide the http.Response ( sdk has abstracted that away ). so now the caller is only provided the data and error for example: data, err := client.MigrateRepo(opts)

lunny commented

2021-10-31 00:47:22 +00:00

I like the first one.

👍 1

dachary referenced this issue

2022-04-26 15:41:54 +00:00

on failure error messages are discarded #582

jolheiser referenced a pull request that will close this issue

2022-04-26 20:00:37 +00:00

Return error message for 4xx errors #583

6543 referenced this issue from a commit

2022-04-28 02:56:34 +00:00