Add GetFileReader() & GetFile() support git-lfs #595

						
				@ -39,10 +39,12 @@ func TestGetGlobalSettings(t *testing.T) {

					attachSettings, _, err := c.GetGlobalAttachmentSettings()

					assert.NoError(t, err)

					if assert.True(t, len(attachSettings.AllowedTypes) > 100) {

KN4CK3R commented

2022-07-29 06:37:11 +00:00

Why is this needed?

6543 commented

2022-07-29 10:06:06 +00:00

since default values have changed we get this: https://drone.gitea.com/gitea/go-sdk/575/1/3

this check does only check if there are enough vars but not fail if a single bit will change again

since default values have changed we get this: https://drone.gitea.com/gitea/go-sdk/575/1/3 this check does only check if there are enough vars but not fail if a single bit will change again

KN4CK3R commented

2022-07-29 10:24:16 +00:00

Changed to assert.NotEmpty

Changed to `assert.NotEmpty`

KN4CK3R marked this conversation as resolved

6543 added 1 commit 2022-07-29 10:22:06 +00:00

nit

continuous-integration/drone/push Build is failing

Details

continuous-integration/drone/pr Build is passing

Details

e0dd72c9f9

KN4CK3R approved these changes 2022-07-29 10:23:42 +00:00

6543 merged commit cc14c63ccc into master

2022-07-29 10:51:06 +00:00

6543 referenced this issue from a commit

2022-07-29 10:51:06 +00:00

Add GetFileReader() & GetFile() support git-lfs (#595)

6543 deleted branch getFile_supportLFS_and_add_GetFileReader

2022-07-29 10:51:06 +00:00

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#595